test: refactor to await #44689
Merged
test: refactor to await #44689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Trott
added
code-and-learn
Trott
approved these changes
Sep 20, 2022
Trott
added
the
author ready
github-actions
bot
removed
the
request-ci
Changes the promises to async/await in test/parallel/test-debugger-invalid-json.
Trott
force-pushed
the
refactor-test-debugger-invalid-json
branch
from
780fac5
to
5b4106c
Compare
github-actions
bot
removed
the
request-ci
This was referenced Sep 26, 2022
This was referenced Sep 28, 2022
Trott
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/44689 ✔ Done loading data for nodejs/node/pull/44689 ----------------------------------- PR info ------------------------------------ Title test: refactor to await (#44689) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch anjanakvellore:refactor-test-debugger-invalid-json -> nodejs:main Labels test, code-and-learn, author ready, needs-ci Commits 1 - test: use await in test-debugger-invalid-json Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/44689 Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44689 Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test: use await in test-debugger-invalid-json ℹ This PR was created on Fri, 16 Sep 2022 21:20:22 GMT ✔ Approvals: 1 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44689#pullrequestreview-1113090104 ℹ This PR is being fast-tracked because it is from a Code and Learn event ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-09-29T14:14:20Z: https://ci.nodejs.org/job/node-test-pull-request/46940/ - Querying data for job/node-test-pull-request/46940/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3153811990 |
Trott
approved these changes
Sep 29, 2022
Trott
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 70047b0 |
|
Thanks for the contribution! 🎉 |
This was referenced Sep 30, 2022
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
Changes the promises to async/await in test/parallel/test-debugger-invalid-json. PR-URL: #44689 Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the promises to async/await in
test/parallel/test-debugger-invalid-json.