Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve assert message #4461

Closed
wants to merge 1 commit into from
Closed

test: improve assert message #4461

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 29, 2015

Improves the message when an assertion fires in the
test-net-pipe-connect-errors so that it indicates the incorrect value
received rather than merely reporting that the value is incorrect.

@Trott
test: improve assert message
6d4288c 
Improves the message when an assertion fires in the
test-net-pipe-connect-errors so that it indicates the incorrect value
received rather than merely reporting that the value is incorrect.
@Trott Trott added the test Issues and PRs related to the tests. label Dec 29, 2015
@Trott
Copy link
Member Author

Trott commented Dec 29, 2015

CI: https://ci.nodejs.org/job/node-test-commit/1565/

@mscdex mscdex added the net Issues and PRs related to the net subsystem. label Dec 29, 2015
@Trott
Copy link
Member Author

Trott commented Dec 29, 2015

Before:

AssertionError: false == true

After:

AssertionError: received ENOENT instead of ENOTSOCK or ECONNREFUSED

@cjihrig
Copy link
Contributor

cjihrig commented Dec 29, 2015

LGTM

2 similar comments
@jbergstroem
Copy link
Member

LGTM

@MylesBorins
Copy link
Contributor

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Dec 31, 2015
@Trott
test: improve assert message
242d078 
Improves the message when an assertion fires in the
test-net-pipe-connect-errors so that it indicates the incorrect value
received rather than merely reporting that the value is incorrect.

PR-URL: nodejs#4461
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@Trott
Copy link
Member Author

Trott commented Dec 31, 2015

Landed in 242d078

@Trott Trott closed this Dec 31, 2015
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
@Trott @Fishrock123
test: improve assert message
3bfc187 
Improves the message when an assertion fires in the
test-net-pipe-connect-errors so that it indicates the incorrect value
received rather than merely reporting that the value is incorrect.

PR-URL: nodejs#4461
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
@Trott
test: improve assert message
b539ff8 
Improves the message when an assertion fires in the
test-net-pipe-connect-errors so that it indicates the incorrect value
received rather than merely reporting that the value is incorrect.

PR-URL: #4461
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@Trott
test: improve assert message
1ae0e35 
Improves the message when an assertion fires in the
test-net-pipe-connect-errors so that it indicates the incorrect value
received rather than merely reporting that the value is incorrect.

PR-URL: #4461
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
test: improve assert message
69d94bd 
Improves the message when an assertion fires in the
test-net-pipe-connect-errors so that it indicates the incorrect value
received rather than merely reporting that the value is incorrect.

PR-URL: nodejs#4461
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@Trott Trott deleted the assert-message branch January 13, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @cjihrig @jbergstroem @MylesBorins @mscdex @jasnell