doc: improvements to dns.markdown copy #4449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General improvements to dns.markdown copy and examples
jasnell
added
doc
| @@ -49,19 +46,20 @@ resolves the IP addresses which are returned. | |||
| }); | |||
| }); | |||
|
|
|||
| There are subtle consequences in choosing one or another, please consult the | |||
| [Implementation considerations section][] for more information. | |||
| There are subtle consequences in choosing one over the other another, | |||
|
@silverwind ... pushed some updates and added some comments. PTAL |
|
LGTM |
|
|
||
| ## dns.getServers() | ||
|
|
||
| Returns an array of IP addresses as strings that are currently being used for | ||
| resolution | ||
| Returns an array of IP address strings that are currently being used for name |
|
@Trott ... fixed! |
|
LGTM |
jasnell
added a commit
that referenced
this pull request
Dec 30, 2015
General improvements to dns.markdown copy and examples PR-URL: #4449 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
|
Landed in 7ee1685 |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
General improvements to dns.markdown copy and examples PR-URL: nodejs#4449 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 13, 2016
General improvements to dns.markdown copy and examples PR-URL: #4449 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
General improvements to dns.markdown copy and examples PR-URL: #4449 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
General improvements to dns.markdown copy and examples PR-URL: nodejs#4449 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General improvements to dns.markdown copy and examples