Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: exports & imports invalid slash deprecation #44477

Merged
merged 10 commits into from
Sep 11, 2022
+176 −65
Merged

module: exports & imports invalid slash deprecation #44477

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
48eef5e
module: exports & imports valid slash deprecation
guybedford Sep 1, 2022
a3f6d87
fixup: linting fixes
guybedford Sep 1, 2022
5d3dd2d
fixup: linting
guybedford Sep 1, 2022
51ef520
fixup: deprecation code
guybedford Sep 1, 2022
14d9ea1
Add tests with subpath mapped to `null`
aduh95 Sep 1, 2022
ca1cecf
add deprecation cases
guybedford Sep 1, 2022
222c820
add note
guybedford Sep 2, 2022
fc4c1de
fixup: pr feedback
guybedford Sep 4, 2022
31a68ef
fixup: spacing
guybedford Sep 6, 2022
eecd2ba
Update lib/internal/modules/esm/resolve.js
guybedford Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add deprecation cases
  • Loading branch information
@guybedford
guybedford committed Sep 1, 2022
commit ca1cecf8026c9da78eea5683afbea58a4ac95093
6 changes: 6 additions & 0 deletions test/es-module/test-esm-exports-deprecations.mjs
View file
Original file line number Diff line number Diff line change
@@ -7,10 +7,16 @@ const expectedWarnings = [
'Use of deprecated leading or trailing slash',
'Use of deprecated double slash',
'.//asdf.js',
'".//internal/test.js"',
'".//internal//test.js"',
'"./////internal/////test.js"',
'"./trailing-pattern-slash/"',
'"./subpath/dir1/dir1.js"',
'"./subpath//dir1/dir1.js"',
'.//asdf.js',
'".//internal/test.js"',
'".//internal//test.js"',
'"./////internal/////test.js"',
'no_exports',
'default_index',
];