Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove v8abbr.h #44402

Merged
merged 1 commit into from
Aug 30, 2022
Merged

src: remove v8abbr.h #44402

merged 1 commit into from
Aug 30, 2022

Conversation

tniessen
Copy link
Member

As far as I can tell, the definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only used for dtrace, which has been removed.

Refs: #43652

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Aug 25, 2022
@tniessen
src: remove v8abbr.h
78cefeb 
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only
used for dtrace, which has been removed.

Refs: nodejs#43652
@tniessen
Copy link
Member Author

Pacified format-cpp.

bnoordhuis
bnoordhuis approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this as a todo so thank you for taking it off my plate, Tobias. :-)

As an aside: I don't think it's always correct to read the second field from ExternalString because that's a cached data pointer (i.e., can be nullptr) but since no one's complained so far...

(The first field points to the Canonical Source of Truth but decoding the pointee is involved.)

@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 26, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Aug 27, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46286/

@github-actions github-actions bot mentioned this pull request Aug 29, 2022
Open
30 tasks
@github-actions github-actions bot mentioned this pull request Aug 30, 2022
Open
27 tasks
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2022
@nodejs-github-bot nodejs-github-bot merged commit ad41c91 into nodejs:main Aug 30, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in ad41c91

This was referenced Aug 31, 2022
Open
Open
RafaelGSS pushed a commit that referenced this pull request Sep 5, 2022
@tniessen @RafaelGSS
src: remove v8abbr.h
24344ce 
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only
used for dtrace, which has been removed.

Refs: #43652
PR-URL: #44402
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 5, 2022
Merged
@RafaelGSS RafaelGSS added dont-land-on-v14.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Sep 6, 2022
@RafaelGSS
Copy link
Member

Adding dont-land labels because this PR depends on a semver-major change #43652

MoLow pushed a commit to MoLow/node that referenced this pull request Sep 7, 2022
@tniessen @MoLow
src: remove v8abbr.h
2ea7dcb 
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only
used for dtrace, which has been removed.

Refs: nodejs#43652
PR-URL: nodejs#44402
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@joyeecheung joyeecheung mentioned this pull request Sep 8, 2022
Closed
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@tniessen @Fyko
src: remove v8abbr.h
25d5325 
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only
used for dtrace, which has been removed.

Refs: nodejs#43652
PR-URL: nodejs#44402
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Oct 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tniessen @nodejs-github-bot @RafaelGSS @bnoordhuis @jasnell @addaleax @gengjiawen @joyeecheung @RaisinTen