Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use --port=0 in debugger tests that do not have to work on 9229 #44342

Closed
wants to merge 1 commit into from
Closed

test: use --port=0 in debugger tests that do not have to work on 9229 #44342

wants to merge 1 commit into from

Commits on Aug 22, 2022

  1. test: use --port=0 in debugger tests that do not have to work on 9229 

    To avoid failures when there is another running process occupying
the port 9229 which may happen if there is a stale process, use the
--port argument of node-inspect to use a random port in tests that
don't have to work on port 9229.

The following tests are not touched:

- test-debugger-launch: specifically needs to test port 9229
- test-debugger-pid: needs modifications to node-inspect
- test-debugger-random-port-with-inspect-port: same as -pid test
    @joyeecheung
    joyeecheung committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    9c0441e View commit details
    Browse the repository at this point in the history