[v18.x] src: split property helpers from node::Environment #44251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
|
/cc @danielleadams |
|
The file that linter is complaining about is not changed in this PR. I'll leave it to releasers to determine what to do with the staging branch. |
danielleadams
force-pushed
the
v18.x-staging
branch
from
96c3373
to
e028edb
Compare
|
Hi @legendecas - I had to update v18.x-staging, so this will need a rebase |
PR-URL: nodejs#44056 Refs: nodejs#42528 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Feng Yu <[email protected]>
legendecas
force-pushed
the
backport-44056-to-18
branch
from
b956ac4
to
aed3566
Compare
|
@danielleadams rebased. |
ruyadorno
approved these changes
Aug 21, 2022
|
Landed in 68ee8e9 |
ruyadorno
pushed a commit
that referenced
this pull request
Aug 21, 2022
PR-URL: #44056 Backport-PR-URL: #44251 Refs: #42528 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Feng Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #44056
Refs: #42528
Reviewed-By: Ben Noordhuis [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Joyee Cheung [email protected]
Reviewed-By: Feng Yu [email protected]