-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix WPT runner result #44238
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
daeyeon:main.wpt-runner-220815.Mon.52ac
Aug 26, 2022
Merged
test: fix WPT runner result #44238
nodejs-github-bot
merged 1 commit into
nodejs:main
from
daeyeon:main.wpt-runner-220815.Mon.52ac
Aug 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't include the other tests for the result when running a specific test in WPT. Signed-off-by: Daeyeon Jeong [email protected]
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Aug 14, 2022
lpinca
approved these changes
Aug 14, 2022
panva
added
request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Aug 14, 2022
panva
approved these changes
Aug 14, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 14, 2022
antsmartian
approved these changes
Aug 15, 2022
daeyeon
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 26, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 26, 2022
Landed in a5d27f4 |
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 5, 2022
This doesn't include the other tests for the result when running a specific test in WPT. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #44238 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
This doesn't include the other tests for the result when running a specific test in WPT. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: nodejs#44238 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Depends on #43455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't include the other tests in the result when running a specific test in WPT.
The following is a result tested with #44234.
To-Be
As-Is
Signed-off-by: Daeyeon Jeong [email protected]