Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add OpenSSL 3.x providers test #44148

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

richardlau
Copy link
Member

Add basic tests for providers when using OpenSSL 3.x.


Intent is to add these basic tests and then extend in a follow up PR to cover e.g. fips.

cc @nodejs/crypto

Add basic tests for providers when using OpenSSL 3.x.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 5, 2022
@richardlau richardlau added crypto Issues and PRs related to the crypto subsystem. openssl Issues and PRs related to the OpenSSL dependency. labels Aug 5, 2022
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 5, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 5, 2022
@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added the review wanted PRs that need reviews. label Aug 11, 2022
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2022
@nodejs-github-bot nodejs-github-bot merged commit 53ec358 into nodejs:main Aug 24, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 53ec358

RafaelGSS pushed a commit that referenced this pull request Sep 5, 2022
Add basic tests for providers when using OpenSSL 3.x.

PR-URL: #44148
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
Add basic tests for providers when using OpenSSL 3.x.

PR-URL: nodejs#44148
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
richardlau added a commit to richardlau/node-1 that referenced this pull request Sep 28, 2022
IBM i PASE Node.js always links to shared openssl
libraries. Skip recently added OpenSSL addons
tests as we do for other OpenSSL addons tests on
IBM i.

Refs: nodejs#31967
Refs: nodejs#44148
@richardlau richardlau mentioned this pull request Sep 29, 2022
4 tasks
@juanarbol
Copy link
Member

Node.js v16.x uses OpenSSL 1.1.1q+quic

nodejs-github-bot pushed a commit that referenced this pull request Oct 2, 2022
IBM i PASE Node.js always links to shared openssl
libraries. Skip recently added OpenSSL addons
tests as we do for other OpenSSL addons tests on
IBM i.

Refs: #31967
Refs: #44148
PR-URL: #44810
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
IBM i PASE Node.js always links to shared openssl
libraries. Skip recently added OpenSSL addons
tests as we do for other OpenSSL addons tests on
IBM i.

Refs: #31967
Refs: #44148
PR-URL: #44810
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. review wanted PRs that need reviews. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants