Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use a typed array internally for process._exiting #43883

Merged
merged 7 commits into from
Jul 31, 2022
Merged

src: use a typed array internally for process._exiting #43883

merged 7 commits into from
Jul 31, 2022

Commits on Jul 18, 2022

  1. src: use a typed array internally for process._exiting 

    This would prevent manual writes to the _exiting JS property on the
process object by passing the data directly via a typed array for
performance.

This change partially addresses this TODO:
https://github.com/nodejs/node/blob/3d575a4f1bd197c3ce669758a2a3c763462a883a/src/api/hooks.cc#L68-L71

Signed-off-by: Darshan Sen <[email protected]>
    @RaisinTen
    RaisinTen committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    728c0de View commit details
    Browse the repository at this point in the history

  2. Update src/node_process_object.cc 

    Co-authored-by: Anna Henningsen <[email protected]>
    @RaisinTen @addaleax
    RaisinTen and addaleax authored Jul 18, 2022
    Configuration menu
    Copy the full SHA
    99f6403 View commit details
    Browse the repository at this point in the history

  3. fixup! Update src/node_process_object.cc 

    Signed-off-by: Darshan Sen <[email protected]>
    @RaisinTen
    RaisinTen committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    20ad6c1 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. src: use a private symbol instead of a string key 

    Signed-off-by: Darshan Sen <[email protected]>
    @RaisinTen
    RaisinTen committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    7d3b32e View commit details
    Browse the repository at this point in the history

  2. fixup! clang-format fix 

    Signed-off-by: Darshan Sen <[email protected]>
    @RaisinTen
    RaisinTen committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    1058776 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2022

  1. fixup! stop calling getHiddenValue() every time process._exiting is a… 

    …ccessed

Signed-off-by: Darshan Sen <[email protected]>
    @RaisinTen
    RaisinTen committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    18b29f2 View commit details
    Browse the repository at this point in the history

  2. fixup! fixup! stop calling getHiddenValue() every time process._exiti… 

    …ng is accessed

Signed-off-by: Darshan Sen <[email protected]>
    @RaisinTen
    RaisinTen committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    a9e68be View commit details
    Browse the repository at this point in the history