src: deduplicate SetALPN implementations

[tniessen]

Instead of accepting either a std::string or a mysterious Local<Value>, accept any std::string_view, which can trivially be constructed from both strings and ArrayBufferViews.

This also removes the need to check IsArrayBufferView() inside of SetALPN, which was dead code anyway.

cc @nodejs/cpp-reviewers

[nodejs-github-bot]

Review requested:

• @nodejs/crypto

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45385/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/43756
✔  Done loading data for nodejs/node/pull/43756
----------------------------------- PR info ------------------------------------
Title      src: deduplicate SetALPN implementations (#43756)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     tniessen:src-deduplicate-setalpn -> nodejs:main
Labels     tls, c++, lib / src, author ready, needs-ci
Commits    1
 - src: deduplicate SetALPN implementations
Committers 1
 - Tobias Nießen 
PR-URL: https://github.com/nodejs/node/pull/43756
Reviewed-By: Darshan Sen 
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43756
Reviewed-By: Darshan Sen 
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 10 Jul 2022 08:32:18 GMT
   ✔  Approvals: 3
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43756#pullrequestreview-1033640563
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/43756#pullrequestreview-1034052396
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/43756#pullrequestreview-1034181893
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2022-07-13T08:25:15Z: https://ci.nodejs.org/job/node-test-pull-request/45385/
- Querying data for job/node-test-pull-request/45385/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/2663853856

[tniessen]

I don't really understand what the bot is complaining about now... everything is green. Some earlier run? The skipped checks?

[F3n67u]

I don't really understand what the bot is complaining about now... everything is green. Some earlier run? The skipped checks?

Github API shows that there is several check suite is canceled so that commit queue refuse to land this pr. Use the following command to query check suite info:

gh api \
  -H "Accept: application/vnd.github+json" \
  /repos/nodejs/node/commits/c39376628881d70c4e27b87216a6b9191ad1a1c1/check-suites 

see also: https://docs.github.com/en/rest/checks/suites#list-check-suites-for-a-git-reference

I cannot find which check is canceled in the GitHub API response, so I cannot narrow down this problem further.

Related code: https://github.com/nodejs/node-core-utils/blob/5247dc0c64c700cd47c5221410e2359881bba046/lib/pr_checker.js#L372-L375

[tniessen]

Yeah, that was one of my two suspicions... seems like a tooling bug then, since the latest checks all passed?

[aduh95]

Landed in 859967a

[targos]

Cannot land on v16.x because std::string_view is C++17