stream: add bytesRead property for readable #4372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
stream
|
I'm cool w/ the change, but there a test that can be added? Also should probably be accompanied by a docs addition. |
|
Thanks, @trevnorris , I'd like to add test and docs. |
JacksonTian
force-pushed
the
bytes_read
branch
3 times, most recently
from
05727c1
to
d559dd7
Compare
|
Add test cases and docs. |
|
|
||
| var Readable = require('stream').Readable; | ||
| var Duplex = require('stream').Duplex; | ||
| var Transform = require('stream').Transform; |
There was a problem hiding this comment.
Preempting the request from others to make these const
EDIT: and anywhere else that the variable doesn't change.
|
Few comments but LGTM otherwise. |
Add a bytesRead property for readable is useful in some use cases. When user want know how many bytes read of readable, need to caculate it in userland. If encoding is specificed, get the value is very slowly.
JacksonTian
force-pushed
the
bytes_read
branch
from
d559dd7
to
9a2a446
Compare
|
Thanks @trevnorris , I updated by your suggestion. |
|
LGTM |
1 similar comment
|
LGTM |
|
Really looking forward to this 👍 |
|
LGTM. Getting a fresh CI run: https://ci.nodejs.org/job/node-test-pull-request/1234/ |
|
Failures in CI look unrelated |
jasnell
pushed a commit
that referenced
this pull request
Jan 15, 2016
Add a bytesRead property for readable is useful in some use cases. When user want know how many bytes read of readable, need to caculate it in userland. If encoding is specificed, get the value is very slowly. PR-URL: #4372 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in bfb2cd0 |
| @@ -135,6 +137,7 @@ function readableAddChunk(stream, state, chunk, encoding, addToFront) { | |||
| var e = new Error('stream.unshift() after end event'); | |||
| stream.emit('error', e); | |||
| } else { | |||
| stream.bytesRead += state.objectMode ? 0 : chunk.length; | |||
There was a problem hiding this comment.
Are you really sure this tracks bytes and not characters?
There was a problem hiding this comment.
There is an edge case, when encoding of this.push(string) is same as encoding readable, the string was just pass though.
There was a problem hiding this comment.
Sounds like a bit of a problem then? :(
There was a problem hiding this comment.
Do we need to revert this?
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Jan 18, 2016
This reverts commit bfb2cd0. Refs: nodejs#4372
cjihrig
added a commit
that referenced
this pull request
Jan 18, 2016
This reverts commit bfb2cd0. The bytesRead property, as implemented, tracks characters instead of bytes when using an identity encoding. Refs: #4372 PR-URL: #4746 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
Fishrock123
added
dont-land-on-v5.x
and removed
semver-major
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Add a bytesRead property for readable is useful in some use cases. When user want know how many bytes read of readable, need to caculate it in userland. If encoding is specificed, get the value is very slowly. PR-URL: nodejs#4372 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
This reverts commit bfb2cd0. The bytesRead property, as implemented, tracks characters instead of bytes when using an identity encoding. Refs: nodejs#4372 PR-URL: nodejs#4746 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a bytesRead property for readable is
useful in some use cases.
When user want know how many bytes read of
readable, need to caculate it in userland.
If encoding is specificed, get the value is
very slowly.