Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor to top-level await #43366

Merged
merged 2 commits into from
Jun 19, 2022
Merged

test: refactor to top-level await #43366

merged 2 commits into from
Jun 19, 2022

Conversation

meekdenzo
Copy link
Contributor

This refactors to top-level await.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 10, 2022
@Trott
Copy link
Member

Trott commented Jun 10, 2022

Did you mean to include all these commits or just 49967ef?

49967ef adds the .mjs file but it also needs to delete the previous .js file I think?

@meekdenzo
Copy link
Contributor Author

meekdenzo commented Jun 10, 2022 •
edited by VoltrexKeyva
Loading

49967ef

Just 49967ef. I made the commit from the same branch.

@Trott
Copy link
Member

Trott commented Jun 12, 2022

This seems to add test/parallel/test-debugger-extract-function-name.mjs but doesn't remove test/parallel/test-debugger-extract-function-name.js.

@meekdenzo
Copy link
Contributor Author

This seems to add test/parallel/test-debugger-extract-function-name.mjs but doesn't remove test/parallel/test-debugger-extract-function-name.js.

Would you recommend closing this PR and opening a new one from a diff branch?

@Trott
Copy link
Member

Trott commented Jun 13, 2022

This seems to add test/parallel/test-debugger-extract-function-name.mjs but doesn't remove test/parallel/test-debugger-extract-function-name.js.

Would you recommend closing this PR and opening a new one from a diff branch?

You can do that, but I would recommend these steps instead:

  1. Use an interactive rebase (git rebase -i upstream/master) to remove the commits you don't want.
  2. Remove test-debugger-extract-function-name.js if that is in fact correct.
  3. Commit that change.
  4. Force push the result: git push --force-with-lease origin test-debugger-extract-function-name-modify

@meekdenzo meekdenzo force-pushed the test-debugger-extract-function-name-modify branch 2 times, most recently from 503e2f5 to 16d5942 Compare June 16, 2022 15:14
@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 16, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 16, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44624/

@github-actions github-actions bot mentioned this pull request Jun 17, 2022
Open
31 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44650/

@github-actions github-actions bot mentioned this pull request Jun 18, 2022
Open
34 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44678/

@F3n67u F3n67u mentioned this pull request Jun 18, 2022
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44681/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44688/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44690/

@Trott Trott force-pushed the test-debugger-extract-function-name-modify branch from 16d5942 to fcb6136 Compare June 18, 2022 14:40
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44693/

@Trott Trott mentioned this pull request Jun 18, 2022
Closed
@github-actions github-actions bot mentioned this pull request Jun 19, 2022
Open
30 tasks
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit 94020ac into nodejs:main Jun 19, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 94020ac

This was referenced Jun 20, 2022
Open
Open
Open
targos pushed a commit that referenced this pull request Jul 12, 2022
@meekdenzo @targos
test: refactor to top-level await
a9ab41c 
PR-URL: #43366
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 18, 2022
@meekdenzo @targos
test: refactor to top-level await
dfa8bbb 
PR-URL: #43366
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@meekdenzo @targos
test: refactor to top-level await
9c1fffc 
PR-URL: #43366
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@meekdenzo @guangwong
test: refactor to top-level await
72e7249 
PR-URL: nodejs/node#43366
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meekdenzo @Trott @nodejs-github-bot @jasnell