Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: add trailing commas #43127

Merged
merged 1 commit into from
May 18, 2022
Merged

Conversation

LiviaMedeiros
Copy link
Contributor

Aligns trailing commas in object destructuring

Refs: #42601 (comment), #42601 (comment), #42601 (comment)

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels May 17, 2022
@LiviaMedeiros LiviaMedeiros added the fast-track PRs that do not need to wait for 48 hours to land. label May 17, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @LiviaMedeiros. Please 👍 to approve.

@nodejs-github-bot

This comment was marked as outdated.

@marsonya marsonya added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 17, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

PR-URL: nodejs#43127
Co-authored-by: Antoine du Hamel <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
@LiviaMedeiros
Copy link
Contributor Author

Landed in fe027da

bengl pushed a commit that referenced this pull request May 30, 2022
PR-URL: #43127
Co-authored-by: Antoine du Hamel <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
@bengl bengl mentioned this pull request May 31, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #43127
Co-authored-by: Antoine du Hamel <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #43127
Co-authored-by: Antoine du Hamel <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43127
Co-authored-by: Antoine du Hamel <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43127
Co-authored-by: Antoine du Hamel <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43127
Co-authored-by: Antoine du Hamel <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants