Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: add options to util.promisify() #43088

Closed
wants to merge 9 commits into from
Closed

util: add options to util.promisify() #43088

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0eb82b3
util: add `options` to util.promisify()
LiviaMedeiros May 13, 2022
d189f86
squash: add test
LiviaMedeiros May 16, 2022
fd7fc12
squash: add `resolveObject` option
LiviaMedeiros May 18, 2022
9420a34
squash: add explicit default `undefined` for optional parameter
LiviaMedeiros May 18, 2022
eba911f
squash: avoid creating throwaway object
LiviaMedeiros May 18, 2022
6f42043
squash: add `noCustom` option
LiviaMedeiros May 20, 2022
c3ff4b4
squash: fix affix
LiviaMedeiros May 20, 2022
77a32b7
squash: fix affix in docs
LiviaMedeiros May 20, 2022
a47750e
squash: make noCustom implicit
LiviaMedeiros May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: add explicit default undefined for optional parameter 
Co-authored-by: Antoine du Hamel <[email protected]>
  • Loading branch information
@LiviaMedeiros @aduh95
LiviaMedeiros and aduh95 authored May 18, 2022
commit 9420a34cee79b704dd47fcd9985d6ec12a1f2c8b
2 changes: 1 addition & 1 deletion lib/internal/util.js
View file
Original file line number Diff line number Diff line change
@@ -323,7 +323,7 @@ const kCustomPromisifyArgsSymbol = Symbol('customPromisifyArgs');
let validateFunction;
let validateInteger;

function promisify(original, options) {
function promisify(original, options = undefined) {
// Lazy-load to avoid a circular dependency.
if (validateFunction === undefined || validateInteger === undefined) {
({