Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gyp: fix direct run gyp bug #42986

Closed
wants to merge 1 commit into from
Closed

Conversation

gengjiawen
Copy link
Member

This fix #40518 (comment)

Repro:

python3 tools/gyp_node.py -f cmake

@gengjiawen gengjiawen requested a review from danbev May 6, 2022 09:09
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dont-land-on-v12.x gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels May 6, 2022
targos
targos previously requested changes May 6, 2022
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upstream to nodejs/gyp-next

@gengjiawen
Copy link
Member Author

Please upstream to nodejs/gyp-next

Sadly the original changes (introduced by openssl 3) only in this repo for now. #40735

@targos
Copy link
Member

targos commented May 6, 2022

Ah, that's unfortunate :(

@gengjiawen
Copy link
Member Author

directly add it to nodejs/gyp-next#147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants