wasm: add missing init reported by coverity

[mhdawson]

Signed-off-by: Michael Dawson [email protected]

[mhdawson]

Report from coverity:

26 private:
27  WasmStreamingObject(Environment* env, v8::Local<v8::Object> object)
28      : BaseObject(env, object) {
29    MakeWeak();
  	
CID 254660 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member wasm_size_ is not initialized in this constructor nor in any functions that it calls.
30  }
31
32  ~WasmStreamingObject() override {}
33
34 private:
35  static void New(const v8::FunctionCallbackInfo<v8::Value>& args);
36  static void SetURL(const v8::FunctionCallbackInfo<v8::Value>& args);
37  static void Push(const v8::FunctionCallbackInfo<v8::Value>& args);
38  static void Finish(const v8::FunctionCallbackInfo<v8::Value>& args);
39  static void Abort(const v8::FunctionCallbackInfo<v8::Value>& args);
40
41  std::shared_ptr<v8::WasmStreaming> streaming_;
  	1. member_decl: Class member declaration for wasm_size_.
42  size_t wasm_size_;
43};

[tniessen]

FWIW, this is where the initialization currently happens:

node/src/node_wasm_web_api.cc

Lines 58 to 70 in 68fb0bf

	Local<Function> ctor = Initialize(env);
	Local<Object> obj;
	if (!ctor->NewInstance(env->context(), 0, nullptr).ToLocal(&obj)) {
	return MaybeLocal<Object>();
	}
	CHECK(streaming);
	WasmStreamingObject* ptr = Unwrap<WasmStreamingObject>(obj);
	CHECK_NOT_NULL(ptr);
	ptr->streaming_ = streaming;
	ptr->wasm_size_ = 0;
	return obj;

Other functions rely on the assumption that the initialization ran (e.g., will abort the process if streaming_ has not been initialized to a non-nullptr value).

Eventually, we might want to revisit how we initialize C++ backed JS objects in general.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/43837/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/43844/

[mhdawson]

Landed in 7649989

[juanarbol]

Backport refs: #42701