lib,src: use Response URL as WebAssembly location #42842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per Section 3 of the WebAssembly Web API spec.
|
Review requested:
|
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
devsnek
approved these changes
Apr 23, 2022
tniessen
added
the
author ready
aduh95
approved these changes
Apr 24, 2022
This was referenced Apr 24, 2022
tniessen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4f9bc41 |
This was referenced Apr 26, 2022
targos
pushed a commit
that referenced
this pull request
Apr 28, 2022
As per Section 3 of the WebAssembly Web API spec. PR-URL: #42842 Refs: #42701 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
|
#42701 is pending to backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per (non-normative) Section 3 of the WebAssembly Web API spec, if the
Responsehas aurl, pass it to V8 so that V8 can construct a conforming WebAssembly location.Refs: #42701