Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: usemustSucceed instead of mustCall with assert.ifError #42806

Merged
merged 1 commit into from
May 5, 2022
Merged

test: usemustSucceed instead of mustCall with assert.ifError #42806

merged 1 commit into from
May 5, 2022

Conversation

fossamagna
Copy link
Contributor

Use mustSucceed instead of mustCall + ifError.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 21, 2022
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 21, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43611/

This was referenced Apr 22, 2022
Open
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43749/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43830/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2022
@nodejs-github-bot nodejs-github-bot merged commit a571a3f into nodejs:master May 5, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in a571a3f

RafaelGSS pushed a commit that referenced this pull request May 10, 2022
@fossamagna @RafaelGSS
test: usemustSucceed instead of mustCall with assert.ifError
b1c18ed 
PR-URL: #42806
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 10, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@fossamagna @juanarbol
test: usemustSucceed instead of mustCall with assert.ifError
db1d714 
PR-URL: #42806
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@fossamagna @danielleadams
test: usemustSucceed instead of mustCall with assert.ifError
08595f4 
PR-URL: #42806
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@fossamagna @targos
test: usemustSucceed instead of mustCall with assert.ifError
a144b62 
PR-URL: #42806
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@fossamagna @targos
test: usemustSucceed instead of mustCall with assert.ifError
fc6456e 
PR-URL: #42806
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@fossamagna @guangwong
test: usemustSucceed instead of mustCall with assert.ifError
d4cb1ff 
PR-URL: nodejs/node#42806
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fossamagna @nodejs-github-bot @lpinca @cjihrig @RaisinTen @VoltrexKeyva @aduh95