-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify error events on HTTP module documentation #4275
Conversation
LGTM |
It might be worth prefixing the addition with something like "As with all |
Makes sense. I'll update it. |
LGTM |
Slight line wrapping nit but I'll fix that when landing... |
Make it clear that error with throw if error listener is not registered. PR-URL: #4275 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Ugh.. flubbed the commit. Landed in 9538fd0 |
Thanks for the fast turnaround. |
Make it clear that error with throw if error listener is not registered. PR-URL: #4275 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Make it clear that error with throw if error listener is not registered. PR-URL: #4275 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Hey @lmarkus! I believe this is your first commit to core, glad to see you got around to it! Thanks for contributing, keep up the great work @ PayPal and I hope to see your name show up more around here! |
Thanks @rvagg! Pretty simple as contributions go, but hopefully there will be more to come 😄 |
Make it clear that error with throw if error listener is not registered. PR-URL: #4275 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Make it clear that error with throw if error listener is not registered. PR-URL: nodejs#4275 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Minor clarification on how errors surface on the HTTP module.
It's not clear that if a listener is not registered, the error will be thrown.
Bumped against it this weekend.