deps: update V8 to 10.1 #42657
Closed
deps: update V8 to 10.1 #42657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
added
the
semver-major
|
Review requested:
|
nodejs-github-bot
added
build
|
@nodejs/tsc |
|
It looks like the 32-bit Windows build has failed: https://ci.nodejs.org/job/node-compile-windows/44578/nodes=win-vs2019-x86/console |
24 tasks
|
|
|
If we look at canary, it failed once on March 25 and was fixed on March 26. Checking the commits that landed on V8 in between... |
|
Added a cherry-pick of v8/v8@a2cae21 |
|
@nodejs/build assuming #42666 lands, how do we handle x86 Windows in CI? |
26 tasks
Opened nodejs/build#2921 to not run the Windows x86 builds for Node.js 18 for now. |
This was referenced Apr 11, 2022
|
FYI https://chromium-review.googlesource.com/c/v8/v8/+/3575468 has landed and it should fix the near heap limit callback issue without a fix in Node.js (I ran a CI with it before and the test passed https://ci.nodejs.org/job/node-test-commit/52817/) |
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 10.1. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
Original commit message:
[testrunner] delete ancient junit compatible format support
Testrunner has ancient support for JUnit compatible XML output.
This CL removes this old feature.
[email protected],[email protected],[email protected]
CC=[email protected]
Bug: v8:8728
Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
Reviewed-on: https://chromium-review.googlesource.com/c/1430065
Reviewed-by: Jakob Gruber <[email protected]>
Reviewed-by: Michael Starzinger <[email protected]>
Commit-Queue: Tamer Tas <[email protected]>
Cr-Commit-Position: refs/heads/master@{#59045}
Refs: v8/v8@bd019bd
PR-URL: nodejs#32116
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
This should be semver-patch since actual invocation is version conditional. PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: nodejs#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs#38807 Refs: nodejs#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]>
`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: nodejs#40488 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]>
We are not ready to migrate yet. Refs: nodejs/node-v8#214 PR-URL: nodejs#40907 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 9, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 10, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 11, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 12, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 13, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 14, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 15, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 16, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 17, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 18, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 19, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 20, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 21, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 22, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 23, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 24, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 25, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 26, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 27, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 28, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 29, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 30, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Dec 31, 2022
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Jan 1, 2023
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Jan 2, 2023
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 2, 2023
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: #42375 PR-URL: #42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Jan 2, 2023
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Jan 3, 2023
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot
pushed a commit
to nodejs/node-v8
that referenced
this pull request
Jan 4, 2023
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* chore: update to Node.js v18 * child_process: improve argument validation nodejs/node#41305 * bootstrap: support configure-time user-land snapshot nodejs/node#42466 * chore: update GN patch * src: disambiguate terms used to refer to builtins and addons nodejs/node#44135 * src: use a typed array internally for process._exiting nodejs/node#43883 * chore: lib/internal/bootstrap -> lib/internal/process * src: disambiguate terms used to refer to builtins and addons nodejs/node#44135 * chore: remove redudant browserGlobals patch * chore: update BoringSSL patch * src: allow embedder-provided PageAllocator in NodePlatform nodejs/node#38362 * chore: fixup Node.js crypto tests - nodejs/node#44171 - nodejs/node#41600 * lib: add Promise methods to avoid-prototype-pollution lint rule nodejs/node#43849 * deps: update V8 to 10.1 nodejs/node#42657 * src: add kNoBrowserGlobals flag for Environment nodejs/node#40532 * chore: consolidate asar initialization patches * deps: update V8 to 10.1 nodejs/node#42657 * deps: update V8 to 9.8 nodejs/node#41610 * src,crypto: remove AllocatedBuffers from crypto_spkac nodejs/node#40752 * build: enable V8's shared read-only heap nodejs/node#42809 * src: fix ssize_t error from nghttp2.h nodejs/node#44393 * chore: fixup ESM patch * chore: fixup patch indices * src: merge NativeModuleEnv into NativeModuleLoader nodejs/node#43824 * [API] Pass OOMDetails to OOMErrorCallback https://chromium-review.googlesource.com/c/v8/v8/+/3647827 * src: iwyu in cleanup_queue.cc * src: return Maybe from a couple of functions nodejs/node#39603 * src: clean up embedder API nodejs/node#35897 * src: refactor DH groups to delete crypto_groups.h nodejs/node#43896 * deps,src: use SIMD for normal base64 encoding nodejs/node#39775 * chore: remove deleted source file * chore: update patches * chore: remove deleted source file * lib: add fetch nodejs/node#41749 * chore: remove nonexistent node specs * test: split report OOM tests nodejs/node#44389 * src: trace fs async api nodejs/node#44057 * http: trace http request / response nodejs/node#44102 * test: split test-crypto-dh.js nodejs/node#40451 * crypto: introduce X509Certificate API nodejs/node#36804 * src: split property helpers from node::Environment nodejs/node#44056 * nodejs/node#38905 bootstrap: implement run-time user-land snapshots via --build-snapshot and --snapshot-blob * lib,src: implement WebAssembly Web API nodejs/node#42701 * fixup! deps,src: use SIMD for normal base64 encoding * fixup! src: refactor DH groups to delete crypto_groups.h * chore: fixup base64 GN file * fix: check that node::InitializeContext() returns true * chore: delete _noBrowserGlobals usage * chore: disable fetch in renderer procceses * dns: default to verbatim=true in dns.lookup() nodejs/node#39987 Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Windows 32 bits CI still fails, I will open another PR to temporarily make that platform experimental, as discussed in this week's TSC meeting.
Edit: failure confirmed: https://ci.nodejs.org/job/node-compile-windows/44578/nodes=win-vs2019-x86/console