Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix line numbers on core errors #4254

Closed
wants to merge 1 commit into from
Closed

src: fix line numbers on core errors #4254

wants to merge 1 commit into from

Commits on Dec 14, 2015

  1. src: fix line numbers on core errors 

    In dfee4e3, the module wrapper
and line offset used when wrapping module code was changed to
better report errors on the first line of modules. However, that
commit did not update the runInThisContext() call used to
execute the core modules, so their error line numbers have been
off by one. This commit provides the correct lineOffset for core
modules.

Refs: nodejs#2867
PR-URL: nodejs#4254
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
    @cjihrig
    cjihrig committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    cad3d23 View commit details
    Browse the repository at this point in the history