-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v17.8.0 proposal #42425
v17.8.0 proposal #42425
Commits on Mar 20, 2022
-
src: fix unchecked return warning from coverity
Fix unchecked return warning from coverity in src/env.cc. Added check in same manner as other places where uv_async_init is called. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #42176 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 62d9a7f - Browse repository at this point
Copy the full SHA 62d9a7fView commit details -
doc: readline
'line'
event emits final lineUpdated docs to reflect current behaviour of readline: final line of input will be emitted via `'line'` event when input stream `'end'` event is emitted even when the input is not newline terminated. Refs: nodejs/node-v0.x-archive#7238 PR-URL: #42214 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 19851f8 - Browse repository at this point
Copy the full SHA 19851f8View commit details -
crypto: add CHECKs to remaining BIO_s_mem allocs
PR-URL: #42155 Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a4632a3 - Browse repository at this point
Copy the full SHA a4632a3View commit details -
tools: fix web streams API links
PR-URL: #42153 Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e95426f - Browse repository at this point
Copy the full SHA e95426fView commit details -
meta: add dependencies label to label-pr-config
PR-URL: #42129 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7fc4b9f - Browse repository at this point
Copy the full SHA 7fc4b9fView commit details -
crypto: fix fingerprint string size calculation
The function generating fingerprint strings never accesses more than EVP_MAX_MD_SIZE * 3 characters, including the terminating '\0'. PR-URL: #42175 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1d0468f - Browse repository at this point
Copy the full SHA 1d0468fView commit details -
build: use ccache in make-v8.sh on ppc64le and s390x
If `ccache` is available, use it during V8 builds on ppc64le and s390x. Only create the `gcc` and `g++` shims if necessary. PR-URL: #42204 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f27bcec - Browse repository at this point
Copy the full SHA f27bcecView commit details -
url: trim leading and trailing C0 control chars
Emulate the WHATWHG URL parse behavior of trimming leading and trailing C0 control characters. This moves url.parse() slightly closer to WHATWHG URL behavior. The current behavior is possibly insecure for some uses. (The url.parse() API is marked as Legacy and the documentation specifically says it has known bugs and insecure behaviors. Still this change makes a lot of sense.) This issue was reported by P0cas. https://github.com/P0cas PR-URL: #42196 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b89f4d5 - Browse repository at this point
Copy the full SHA b89f4d5View commit details -
string_decoder: fix crash when calling __proto__.write()
This makes the function throw an exception from JS instead of crashing. Fixes: #41949 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42062 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mestery <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3492a0e - Browse repository at this point
Copy the full SHA 3492a0eView commit details -
doc: remove refs to old OpenSSL list-* commands
The last release line that did not support the new openssl list command was OpenSSL 1.1.0, which reached its end-of-life status years ago. PR-URL: #42235 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f3c6c00 - Browse repository at this point
Copy the full SHA f3c6c00View commit details -
PR-URL: #42205 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 70c0758 - Browse repository at this point
Copy the full SHA 70c0758View commit details -
lib: fix AsyncResource.bind not using 'this' from the caller by default
PR-URL: #42177 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 69a3792 - Browse repository at this point
Copy the full SHA 69a3792View commit details -
doc: deprecate string coercion in
fs.write
,fs.writeFileSync
This also affects `fs.writeFile`, `fs.appendFile`, and `fs.appendFileSync` Refs: #41677 PR-URL: #42149 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2335467 - Browse repository at this point
Copy the full SHA 2335467View commit details -
src: use
emplace_back
instead ofpush_back
PR-URL: #42159 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9af9083 - Browse repository at this point
Copy the full SHA 9af9083View commit details -
test: use global webcrypto for WPT tests
PR-URL: #42236 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a4aa9eb - Browse repository at this point
Copy the full SHA a4aa9ebView commit details -
src,crypto: avoid tristate Maybe<bool> in ExportJWKEcKey()
The function currently uses the return value to convey whether an exception was thrown while it was running by using either Just(true) or Nothing<bool>(). Unfortunately, Maybe<bool> also has a third state - Just(false), which doesn't make any sense here. So this change avoids the possibility of a tristate return value by making use of Maybe<void> which only has two valid states - JustVoid() / Nothing<void>(), which fits right in. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42223 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 58763d7 - Browse repository at this point
Copy the full SHA 58763d7View commit details -
debugger: correct typo in inspect_repl.js
PR-URL: #42267 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3b55946 - Browse repository at this point
Copy the full SHA 3b55946View commit details -
This also adds a script to automate the update and includes the sources included in the npm tarball. PR-URL: #42246 Fixes: #42199 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b60262e - Browse repository at this point
Copy the full SHA b60262eView commit details -
build: rename tools workflow and add undici to it
The workflow already updates Corepack, which is a `deps`, not a `tool`. Add subsystem and label variables to the matrix to better control the automated pull requests and add undici to the updated deps. PR-URL: #42246 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1796f03 - Browse repository at this point
Copy the full SHA 1796f03View commit details -
doc: remove outdated timeout.unref content
resolve: #42239 PR-URL: #42241 Fixes: #42239 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mestery <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 701dc14 - Browse repository at this point
Copy the full SHA 701dc14View commit details -
http2: fix potential integer overflow
Fix report from coverity on potential integer overflow in http2. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #42248 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 88dee3c - Browse repository at this point
Copy the full SHA 88dee3cView commit details -
esm: add runtime warning for specifier resolution flag
PR-URL: #42252 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4829a10 - Browse repository at this point
Copy the full SHA 4829a10View commit details -
src: perform minor cleanups on zlib code
- Use `final` to indicate the classes that we actually instantiate - Properly use `const` (and the necessary associated `const_cast` for zlib because we don’t define `ZLIB_CONST` and allow shared builds) - Store the JS callback in an internal field rather than a `Global` (which improves memory leak debugging capabilities, removes a potential future memory leak footgun, and aligns the code with the rest of the codebase more closely) - Other minor C++ cleanup PR-URL: #42247 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d06e92d - Browse repository at this point
Copy the full SHA d06e92dView commit details -
deps: V8: cherry-pick c6f6626deb14
Original commit message: [riscv64] Fix segmentation fault of webpack-make from cockpit issue: riscv-collab/v8#520 Change-Id: I7fe298ad16a2f599805929db0f084a81c4eb7f7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3503170 Auto-Submit: Yahan Lu <[email protected]> Reviewed-by: ji qiu <[email protected]> Reviewed-by: Yahan Lu <[email protected]> Commit-Queue: Yahan Lu <[email protected]> Cr-Commit-Position: refs/heads/main@{#79376} Refs: v8/v8@c6f6626 PR-URL: #42240 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 063ff08 - Browse repository at this point
Copy the full SHA 063ff08View commit details -
src: remove redundant buffer size check
This condition is already checked by the CHECK_BUFLEN_IN_RANGE macro, so if it was true here, that would contradict the previous check. PR-URL: #42257 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e43aa30 - Browse repository at this point
Copy the full SHA e43aa30View commit details -
test: add test case for reverted 17.7 regression
Refs: #42279 PR-URL: #42283 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 94e5eaa - Browse repository at this point
Copy the full SHA 94e5eaaView commit details -
url: preserve null char in WHATWG URL errors
A null character in the middle of an invalid URL was resulting in an error message that truncated the input string. This preserves the entire input string in the error message. Refs: #39592 PR-URL: #42263 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fe01940 - Browse repository at this point
Copy the full SHA fe01940View commit details -
src: include internal/options in the snapshot
This patch enables internal/options to be included in the snapshot, so that when lazy loading the run time options, the modules only need to make sure that the options are queried lazily and do not have to lazy load the internal/options module together. We can still guarantee that no run time options are serialized into the state-independent bootstrap snapshot with the assertion inside GetCLIOptions(). PR-URL: #42203 Refs: #37476 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9fc4b9b - Browse repository at this point
Copy the full SHA 9fc4b9bView commit details
Commits on Mar 21, 2022
-
PR-URL: #42317 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e7b8d83 - Browse repository at this point
Copy the full SHA e7b8d83View commit details -
deps: cares: cherry-pick b5a3d96
Original commit message: Asterisks should be allowed in host validation as CNAMEs may reference wildcard domains CloudFlare appears to use this logic in CNAMEs as per #42171 Fixes: c-ares/c-ares#457 Fix By: Brad House (@bradh352) PR-URL: #42216 Fixes: #42171 Fixes: #457 Refs: c-ares/c-ares#457 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f2178fc - Browse repository at this point
Copy the full SHA f2178fcView commit details -
I spent hours trying to make it work only to learn that it's not supported in node anymore, so I thought I'd save other people the time in the future. https://groups.google.com/g/nodejs/c/SxNKLclbM5k?pli=1 PR-URL: #42295 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mestery <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8b99099 - Browse repository at this point
Copy the full SHA 8b99099View commit details -
doc: clarify the meaning of legacy status
Fixes: #42230 Fixes: #42232 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42269 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 72dd500 - Browse repository at this point
Copy the full SHA 72dd500View commit details -
tools: update eslint to 8.11.0
PR-URL: #42318 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for eb0e1a1 - Browse repository at this point
Copy the full SHA eb0e1a1View commit details -
src: check return value of HMAC_Final
PR-URL: #42303 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 08e2d8a - Browse repository at this point
Copy the full SHA 08e2d8aView commit details -
esm: improve typings and code coverage
PR-URL: #42305 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e17db8f - Browse repository at this point
Copy the full SHA e17db8fView commit details -
src: avoid returning invalid value from hex2bin
If the input is not a valid hexadecimal digit, hex2bin should not return an invalid value, which is not handled correctly by the caller, which is the PercentDecode function. However, PercentDecode only ever calls the hex2bin function with valid hexadecimal digits, so mark the code path that previously returned an invalid value for non-digits as UNREACHABLE. PR-URL: #42307 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9500e58 - Browse repository at this point
Copy the full SHA 9500e58View commit details -
src: simplify bound check in ParseArrayIndex
PR-URL: #42306 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8b84e68 - Browse repository at this point
Copy the full SHA 8b84e68View commit details -
tools: update lint-md-dependencies to [email protected] [email protected]
PR-URL: #42316 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joe Sepi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 30ea188 - Browse repository at this point
Copy the full SHA 30ea188View commit details -
tools: update doc to [email protected] [email protected]
PR-URL: #42315 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joe Sepi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b7a4b4b - Browse repository at this point
Copy the full SHA b7a4b4bView commit details -
src: check EC_POINT_get_affine_coordinates result
PR-URL: #42304 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 846b074 - Browse repository at this point
Copy the full SHA 846b074View commit details -
src: fix coverity warnings in node_file.cc
Fix two warnings about a useless call and not checking a return value. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #42272 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 21198c1 - Browse repository at this point
Copy the full SHA 21198c1View commit details -
test: improve _http_outgoing coverage
PR-URL: #42213 Refs: https://coverage.nodejs.org/coverage-29bb2bb57d2a993e/lib/_http_outgoing.js.html Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4941791 - Browse repository at this point
Copy the full SHA 4941791View commit details -
test: improve _http_incoming.js coverage
PR-URL: #42211 Refs: https://coverage.nodejs.org/coverage-010cb714161102de/lib/_http_incoming.js.html Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dfdce7c - Browse repository at this point
Copy the full SHA dfdce7cView commit details -
doc: clarify path search in
child_process.spawn
The documentation about command lookup could be more clear and note differences between Windows and Linux/OSX. Current text gives the impression that if one passes `options.env` without `PATH`, the path search will fall back on `process.env.PATH`. In reality, passing environment without `PATH` to `execvp` causes it to look for the binary only in `/usr/bin:/bin`. Also Windows behaves different and more in line with the current documentation text. PR-URL: #41418 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 96dc591 - Browse repository at this point
Copy the full SHA 96dc591View commit details -
doc: fix async iterable pipeline signal examples
Fix the pipeline examples to show that async generators receive an AbortSignal wrapped in an object. PR-URL: #42258 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fd7e4ab - Browse repository at this point
Copy the full SHA fd7e4abView commit details -
lib: refactor to use primordials in
lib/assert.js
PR-URL: #41702 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mestery <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1fe0b69 - Browse repository at this point
Copy the full SHA 1fe0b69View commit details -
esm: make extension-less errors in type:module actionable
PR-URL: #42301 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e55283b - Browse repository at this point
Copy the full SHA e55283bView commit details -
doc: update base branch name for
nodejs/nodejs.org
PR-URL: #42355 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mestery <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e7e8eb9 - Browse repository at this point
Copy the full SHA e7e8eb9View commit details -
doc: add @ShogunPanda to collaborators
PR-URL: #42362 Fixes: #42245 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3bd0078 - Browse repository at this point
Copy the full SHA 3bd0078View commit details -
stream: do cleanup when iterator is destroyed
PR-URL: #42320 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5367002 - Browse repository at this point
Copy the full SHA 5367002View commit details -
The only significant change is to replace AsyncHooks with `AsyncHook`. PR-URL: #42337 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 46d3d23 - Browse repository at this point
Copy the full SHA 46d3d23View commit details -
doc: remove unneeded lint disable comment
PR-URL: #42374 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6c265e7 - Browse repository at this point
Copy the full SHA 6c265e7View commit details -
doc: fix Embedder's Guide link to V8 official docs
PR-URL: #42373 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a5e42f0 - Browse repository at this point
Copy the full SHA a5e42f0View commit details -
test: improve https_renew_cert.sh script
- To avoid unnecessarily large diffs, only generate a new private key if necessary. Otherwise, reuse the existing private key and only issue a new certificate. - Remove an unnecessary conversion step using openssl rsa and the intermediate rsa.pem and csr.pem files. - Extend the certificate validity from 1 year to 10 years. - Show a text representation of the issued certificate upon completion such that the user can verify the validity. - Make the script executable. - Use "#!/usr/bin/env bash" instead of "#!/bin/bash". - Allow the script to be called from any directory. Refs: #42342 Refs: #37990 PR-URL: #42343 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mestery <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b82bac0 - Browse repository at this point
Copy the full SHA b82bac0View commit details -
worker: do not send message if port is closing
Fixes: #42296 PR-URL: #42357 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 229fb40 - Browse repository at this point
Copy the full SHA 229fb40View commit details -
http: trace http client by perf_hooks
PR-URL: #42345 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for da42ffb - Browse repository at this point
Copy the full SHA da42ffbView commit details -
doc: document goal to have examples
As discussed in next-10 mini-summit on documentation see minutes where next steps were discussed - https://github.com/nodejs/next-10/blob/main/meetings/2022-02-16.md and minutes from summit - https://github.com/nodejs/next-10/blob/main/meetings/2022-02-16.md Signed-off-by: Michael Dawson <[email protected]> PR-URL: #42274 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 78b858d - Browse repository at this point
Copy the full SHA 78b858dView commit details -
src: convert hex2bin() into a regular function
No need to write hex2bin() as a function template because it's only called with a char parameter. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42321 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e960424 - Browse repository at this point
Copy the full SHA e960424View commit details -
test: give slow tests more time on Rasberry PIs
Refs: #42379 A number of tests have been failing internmittently on the Rasberry PIs with timeouts since the update to OpenSSL 3.0. Give them more time. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #42380 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d9a5c2b - Browse repository at this point
Copy the full SHA d9a5c2bView commit details -
doc: update instructions for openssl updates
Update to reflect additional PRs needed as some branches now use OpenSSL 3.x Signed-off-by: Michael Dawson <[email protected]> PR-URL: #42353 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 04a7c00 - Browse repository at this point
Copy the full SHA 04a7c00View commit details -
doc: add that chacha20-poly1305 is IETF version
PR-URL: #42370 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 88d3401 - Browse repository at this point
Copy the full SHA 88d3401View commit details -
PR-URL: #42382 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 84fd6e5 - Browse repository at this point
Copy the full SHA 84fd6e5View commit details -
test,crypto: add and update empty passphrase regression tests
Refs: openssl/openssl#17507 Refs: #41428 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42319 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 26d4a2d - Browse repository at this point
Copy the full SHA 26d4a2dView commit details -
doc: improve README.md usability
* The logo takes a lot of room doesn't add information. * Make Node.js a top-level header and Table of Contents a second-level header. This looks better, improve semantics, makes the README.md more usable in its raw form, and aligns us with README.md practices in other projects like TypeScript and Deno. PR-URL: #42378 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Mestery <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for db83c4d - Browse repository at this point
Copy the full SHA db83c4dView commit details -
crypto: fix auth tag length error when mode != GCM
PR-URL: #42383 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f48c3ba - Browse repository at this point
Copy the full SHA f48c3baView commit details -
tools: update lint-md-dependencies to [email protected]
PR-URL: #42403 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 38e7681 - Browse repository at this point
Copy the full SHA 38e7681View commit details -
PR-URL: #42404 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1c87ce6 - Browse repository at this point
Copy the full SHA 1c87ce6View commit details -
tools: make update-undici script executable
PR-URL: #42406 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4fd2aff - Browse repository at this point
Copy the full SHA 4fd2affView commit details -
doc: fix version history for
net.Socket
andnet.Server
Refs: #41310 Backport-PR-URL: #42270 PR-URL: #42268 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fd51e78 - Browse repository at this point
Copy the full SHA fd51e78View commit details -
2022-03-22, Version 17.8.0 (Current)
Notable changes: doc: * add @ShogunPanda to collaborators (Shogun) #42362 * deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) #42149 http: * (SEMVER-MINOR) trace http client by perf_hooks (theanarkh) #42345 deps: * upgrade npm to 8.5.5 (npm team) #42382 * update undici to 4.15.1 (Michaël Zasso) #42246 PR-URL: #42425
Configuration menu - View commit details
-
Copy full SHA for 123661e - Browse repository at this point
Copy the full SHA 123661eView commit details