Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve lib/internal/readline/promises.js coverage #42420

Merged
merged 6 commits into from
Apr 3, 2022
Merged

test: improve lib/internal/readline/promises.js coverage #42420

merged 6 commits into from
Apr 3, 2022

Commits on Mar 21, 2022

  1. test: improve lib/internal/readline/promises.js coverage

    @fossamagna
    fossamagna committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    ee4cd15 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. test: remove unnecessary await keyword

    @fossamagna
    fossamagna committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    2c52120 View commit details
    Browse the repository at this point in the history

  2. test: use destructuring assignment

    @fossamagna
    fossamagna committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    19a968b View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. test: make test more readable 

    using `await setImmediate` instead of `test` function + process.nextTick.
    @fossamagna
    fossamagna committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    b215d31 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @fossamagna @aduh95
    fossamagna and aduh95 authored Mar 24, 2022
    Configuration menu
    Copy the full SHA
    5c980e5 View commit details
    Browse the repository at this point in the history

  3. test: fix lint error

    @fossamagna
    fossamagna committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    9630466 View commit details
    Browse the repository at this point in the history