Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: use RFC2253 format in PrintGeneralName #42002

Merged

Commits on Feb 16, 2022

  1. crypto: use RFC2253 format in PrintGeneralName

    For backward compatibility, node uses X509_NAME_oneline to format
    X509_NAME entries in PrintGeneralName. However, the format produced by
    this function is non-standard and its use is discouraged. It also does
    not handle Unicode names correctly.
    
    This change switches to X509_NAME_print_ex with flags that produce an
    RFC2253-compatible format. Non-ASCII strings are converted to UTF-8 and
    preserved in the output. Control characters are not escaped by OpenSSL
    when producing the RFC2253 format because they will be escaped by node
    in a JSON-compatible manner afterwards.
    tniessen committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    5cd505a View commit details
    Browse the repository at this point in the history