-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: copyedit child_process doc #4188
Conversation
LGTM |
1 similar comment
LGTM |
have unforeseen consequences: if the PID (the process ID) has been reassigned | ||
to another process, the signal will be delivered to that process instead. | ||
What happens next is anyone's guess. | ||
have unforeseen consequences. Specifically, if the process ID (PID) has been |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe write out process identifier
? I'm not a fan of ID
as it isn't even an abbreviation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree; I'll write it out as identifier
.
PR-URL: #4188 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Landed in 37ed05b |
PR-URL: #4188 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
PR-URL: #4188 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
PR-URL: #4188 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
PR-URL: nodejs#4188 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
No description provided.