doc: copyedit buffer doc #4187
Closed
doc: copyedit buffer doc #4187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
buffer
|
|
||
| * `'ascii'` - for 7 bit ASCII data only. This encoding method is very fast, and | ||
| will strip the high bit if set. | ||
| * `'ascii'` - for 7-bit ASCII data only. This encoding method is very fast, |
There was a problem hiding this comment.
is the comma between "fast" and "and" necessary?
There was a problem hiding this comment.
I agree; it is superfluous.
|
LGTM with a question |
|
Revised per @targos question/comment. |
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 10, 2015
PR-URL: nodejs#4187 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
|
Landed in e47ae58 |
Trott
added a commit
that referenced
this pull request
Dec 15, 2015
PR-URL: #4187 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Closed
Trott
added a commit
that referenced
this pull request
Dec 29, 2015
PR-URL: #4187 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
PR-URL: #4187 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
PR-URL: nodejs#4187 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.