-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update AUTHORS list #4183
doc: update AUTHORS list #4183
Conversation
@rvagg All 3 are me. I prefer [email protected]. Sorry for the confusion on that |
@rvagg you can list me as "Jerry Chin", tks! |
@jkrems you are listed with two different email addresses, see .mailmap in this PR, I've consolidated you under your gmail, which would you prefer? @evanlucas no problems at all, that's what .mailmap is for. @hellopao done, thanks! |
@rvagg Gmail is the preferred one. Guess I messed up my git config for that other commit. |
@rvagg, You can list me as "Caleb Boyd". Thanks! |
You can list me as Jonathan Persson and with my gmail [email protected], thanks! |
Marti Martz Appreciate the acknowledgement for my tiny little contribution. :) P.S. Thanks to your team for all they do. |
@jkrems done |
@calebboyd done |
Hello @rvagg , could you plz put both of my emails, [email protected] and [email protected]? since I couldn't be able to check email while I am not able to connect to the IBM internal network. Thanks! |
thanks @john-yan, I've updated .mailmap to use your gmail.com address, see attached commit. |
That's strange, my github profile has my real name which is Claudio Rodriguez, is that not showing for you? Mail is cjrodr at yahoo dot com |
Thanks @fansworld-claudio, updated. This all comes from git itself, see https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit on how to set up your details in your local .gitconfig which is what determines what goes into your commit log. |
Appreciate the love Rod. Please list me as Martial James Jefferson. Best, Thanks On Tue, Dec 8, 2015 at 12:56 AM, Rod Vagg [email protected] wrote:
|
Hi @rvagg, my preference is [email protected]. Thanks |
Hurray, virtual fame for life! @rvagg Zirak and [email protected] (what you currently have) are more than fine. Thanks for the consideration. |
Hi @rvagg, can you update my email address to [email protected] please? (Dan Kaplun) |
8a38108
to
c618dd7
Compare
9c76a40
to
b2863f9
Compare
@hemanth you are listed here as "Hemanth.HM" due to your git settings. Most of us have a full name listed, would you like to have yours adjusted or are you happy with how it is? |
@rvagg thanks! (BTW I don't have the other email address anymore so the line in |
Friendly reminder to @pflannery, @bcbcb, @wizicer, @jimmyhsu, @stcruy, @DannyNemer @baslr who may have been asked before: your entry in AUTHORS is listed with a GitHub noreply address. Most of us have a real email address listed and it is helpful to the project, if for example in the future we need to adjust licensing terms, however it's by no means mandatory if you'd prefer to not list an address. If you would like it changed, please let me know and I can update your entry. |
b2863f9
to
c55ee67
Compare
@wurde is Andy Bettisworth, hi! [email protected] |
@rvagg Thank for asking, I am happy with |
Thanks @rvagg for the reminder, I'd like to use |
@rvagg diff is fine. |
Once all the author metadata is updated, this LGTM Awesome to see so many names being added! |
Update AUTHORS list using tools/update-authors.sh
c55ee67
to
5d6b899
Compare
@rvagg ... is this about ready? |
Update AUTHORS list using tools/update-authors.sh PR-URL: #4183 Reviewed-By: James M Snell <[email protected]>
done, 59 new authors since last time I did this 2 months ago @ 0116da1! |
👍 |
That's fantastic! Thanks @rvagg!
|
Update AUTHORS list using tools/update-authors.sh PR-URL: #4183 Reviewed-By: James M Snell <[email protected]>
Update AUTHORS list using tools/update-authors.sh PR-URL: #4183 Reviewed-By: James M Snell <[email protected]>
@rvagg Apologies for being so late. I've been busy and didn't notice this until now. Might be too late, but my email for contact is [email protected]. If there's another ticket open for this let me know and I can post it there as I didn't realize it was a github noreply email prior to this. |
Update AUTHORS list using tools/update-authors.sh PR-URL: #4183 Reviewed-By: James M Snell <[email protected]>
Update AUTHORS list using tools/update-authors.sh PR-URL: nodejs#4183 Reviewed-By: James M Snell <[email protected]>
Update AUTHORS list using tools/update-authors.sh
This is a big 'un! We need some input from some individuals this pulls in wrt their details: