Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update Mesteery email #41683

Merged
merged 2 commits into from
Jan 29, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ maintaining the Node.js project.
* [marsonya](https://github.com/marsonya) -
**Akhil Marsonya** <<[email protected]>> (he/him)
* [Mesteery](https://github.com/Mesteery) -
**Mestery** <<mestery@pm.me>>
**Mestery** <<mestery@protonmail.com>> (he/him)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a .mailmap entry for this too so that your entry here matches your entry in AUTHORS and so that you won't show up in AUTHORS twice?

It should look something like this and be placed in the right place in .mailmap alphabetically:

After you add the entry, you can test it by running tools/update-authors.js. That will update the AUTHORS file and automatically change your pm.me entry to protonmail.com. Then add that version of AUTHORS to this PR> (It may also add new entries to the end of the AUTHORS file. You can delete those or leave them as part of this PR.)

All told, three files need to be updated: README.md, .mailmap, and (via the update script) AUTHORS.

* [PoojaDurgad](https://github.com/PoojaDurgad) -
**Pooja Durgad** <<[email protected]>>
* [RaisinTen](https://github.com/RaisinTen) -
Expand Down