Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a
.mailmap
entry for this too so that your entry here matches your entry inAUTHORS
and so that you won't show up inAUTHORS
twice?It should look something like this and be placed in the right place in
.mailmap
alphabetically:After you add the entry, you can test it by running
tools/update-authors.js
. That will update the AUTHORS file and automatically change your pm.me entry to protonmail.com. Then add that version ofAUTHORS
to this PR> (It may also add new entries to the end of the AUTHORS file. You can delete those or leave them as part of this PR.)All told, three files need to be updated:
README.md
,.mailmap
, and (via the update script)AUTHORS
.