Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix npm version detection #41575

Closed
wants to merge 1 commit into from
Closed

build: fix npm version detection #41575

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jan 18, 2022

Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850

@targos
build: fix npm version detection
a8f0fee 
Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 18, 2022
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jan 18, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@targos targos mentioned this pull request Jan 18, 2022
Closed
@targos
Copy link
Member Author

targos commented Jan 18, 2022

Requesting to fast-track because this is blocking today's 17.x release.

@targos
Copy link
Member Author

targos commented Jan 18, 2022

/cc @nodejs/collaborators I have very little time left to do the release.

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2022
mcollina
mcollina approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 18, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/41575
✔  Done loading data for nodejs/node/pull/41575
----------------------------------- PR info ------------------------------------
Title      build: fix npm version detection (#41575)
Author     Michaël Zasso  (@targos)
Branch     targos:fix-pkg -> nodejs:master
Labels     build, fast-track, author ready, needs-ci
Commits    1
 - build: fix npm version detection
Committers 1
 - Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/41575
Fixes: https://github.com/nodejs/build/issues/2850
Reviewed-By: Antoine du Hamel 
Reviewed-By: Vladimir de Turckheim 
Reviewed-By: Filip Skokan 
Reviewed-By: Evan Lucas 
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Zijian Liu 
Reviewed-By: Matteo Collina 
Reviewed-By: Christian Clauss 
Reviewed-By: Tobias Nießen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41575
Fixes: https://github.com/nodejs/build/issues/2850
Reviewed-By: Antoine du Hamel 
Reviewed-By: Vladimir de Turckheim 
Reviewed-By: Filip Skokan 
Reviewed-By: Evan Lucas 
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Zijian Liu 
Reviewed-By: Matteo Collina 
Reviewed-By: Christian Clauss 
Reviewed-By: Tobias Nießen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 18 Jan 2022 10:39:35 GMT
   ✔  Approvals: 10
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41575#pullrequestreview-855244531
   ✔  - Vladimir de Turckheim (@vdeturckheim): https://github.com/nodejs/node/pull/41575#pullrequestreview-855256162
   ✔  - Filip Skokan (@panva): https://github.com/nodejs/node/pull/41575#pullrequestreview-855257311
   ✔  - Evan Lucas (@evanlucas): https://github.com/nodejs/node/pull/41575#pullrequestreview-855285931
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41575#pullrequestreview-855297007
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41575#pullrequestreview-855300576
   ✔  - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/41575#pullrequestreview-855303507
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/41575#pullrequestreview-855307827
   ✔  - Christian Clauss (@cclauss): https://github.com/nodejs/node/pull/41575#pullrequestreview-855343615
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41575#pullrequestreview-855377040
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1712846536

@targos
Copy link
Member Author

targos commented Jan 18, 2022 •
edited
Loading

Landed in 331b906

@targos targos closed this Jan 18, 2022
targos added a commit that referenced this pull request Jan 18, 2022
@targos
build: fix npm version detection
331b906 
Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850

PR-URL: #41575
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos added a commit that referenced this pull request Jan 18, 2022
@targos
build: fix npm version detection
4958c80 
Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850

PR-URL: #41575
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos deleted the fix-pkg branch January 18, 2022 13:24
@targos targos removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 18, 2022
thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
@targos @thedull
build: fix npm version detection
f365414 
Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850

PR-URL: nodejs#41575
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@targos @Linkgoron
build: fix npm version detection
aa07097 
Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850

PR-URL: nodejs#41575
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@targos @danielleadams
build: fix npm version detection
5c1dc5f 
Npm's package.json now contains two fields named "version".
Grep for the top-level one.

Fixes: nodejs/build#2850

PR-URL: #41575
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@vdeturckheim vdeturckheim vdeturckheim approved these changes

@richardlau richardlau richardlau approved these changes

@cclauss cclauss cclauss approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@evanlucas evanlucas evanlucas approved these changes

@panva panva panva approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macOS pkg release build failures