Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16.x backport] deps: update ICU to 70.1 #41525

Closed
wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Jan 14, 2022

This is a clean cherry-pick of #40658
Opened as a PR to check CI.

Do not ask to separate the changes in deps/icu-small and in the
LICENSE file.
Do not ask to remove the whitespace changes. The way commits are
landed now doesn't eliminate them anymore.

PR-URL: nodejs#40658
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v16.x labels Jan 14, 2022
@targos targos added icu Issues and PRs related to the ICU dependency. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added the notable-change PRs with changes that should be highlighted in changelogs. label Jan 14, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 17, 2022

@targos
Copy link
Member Author

targos commented Jan 18, 2022

Landed in 0466400...ab28dc5

@targos targos closed this Jan 18, 2022
@targos targos deleted the icu-70-v16.x branch January 18, 2022 08:28
targos added a commit that referenced this pull request Jan 18, 2022
Refs: https://github.com/unicode-org/icu/releases/tag/release-70-1

PR-URL: #40658
Backport-PR-URL: #41525
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos added a commit that referenced this pull request Jan 18, 2022
Do not ask to separate the changes in deps/icu-small and in the
LICENSE file.
Do not ask to remove the whitespace changes. The way commits are
landed now doesn't eliminate them anymore.

PR-URL: #40658
Backport-PR-URL: #41525
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icu Issues and PRs related to the ICU dependency. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants