-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v12.x] tools: update tzdata to 2021a4 #41443
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertyw
force-pushed
the
update-tzdata
branch
from
January 14, 2022 17:38
e797c22
to
c69b2b2
Compare
richardlau
changed the title
tools: update tzdata to 2021a4
[v12.x] tools: update tzdata to 2021a4
Jan 14, 2022
richardlau
added
the
notable-change
PRs with changes that should be highlighted in changelogs.
label
Jan 14, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 14, 2022
26 tasks
This updates the time zone database up to 2021a4 for the node v12.x-staging branch, following the documentation at https://github.com/nodejs/node/blob/master/doc/guides/maintaining-icu.md#time-zone-data This is essentially a backport of nodejs#40658. Refs: nodejs#40658 Refs: nodejs/Release#576
albertyw
force-pushed
the
update-tzdata
branch
from
January 16, 2022 00:35
c69b2b2
to
00f331a
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 17, 2022
richardlau
approved these changes
Jan 17, 2022
16 tasks
ruyadorno
approved these changes
Jan 26, 2022
Quick check for nodejs/Release#576 (comment): $ nvm run 12 -p 'new Date("2022-02-25T00:00+0000").toLocaleString("en-US", { timeZone: "Asia/Amman" } )'
Running node v12.22.7 (npm v6.14.15)
2/25/2022, 2:00:00 AM with this PR: $ ./node -p 'new Date("2022-02-25T00:00+0000").toLocaleString("en-US", { timeZone: "Asia/Amman" } )'
2/25/2022, 3:00:00 AM |
ruyadorno
pushed a commit
that referenced
this pull request
Jan 26, 2022
This updates the time zone database up to 2021a4 for the node v12.x-staging branch, following the documentation at https://github.com/nodejs/node/blob/master/doc/guides/maintaining-icu.md#time-zone-data This is essentially a backport of #40658. Refs: #40658 Refs: nodejs/Release#576 PR-URL: #41443 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
Landed in d9237c4 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-ci
PRs that need a full CI run.
notable-change
PRs with changes that should be highlighted in changelogs.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the time zone database up to 2021a4 for the node
v12.x-staging
branch, following the documentation athttps://github.com/nodejs/node/blob/master/doc/guides/maintaining-icu.md#time-zone-data.
This is essentially a partial backport of #40658.
Refs: #40658
Refs: nodejs/Release#576