Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to openssl 1.0.1q (v0.10) #4132

Closed
wants to merge 3 commits into from

Conversation

bnoordhuis
Copy link
Member

Contains fixes for:

(v0.10 is not affected by CVE-2015-3193 and CVE-2015-3196.)

OpenSSL did a character encoding fix-up that I've split off into a separate commit to keep down the noise in the main commit.

R=@nodejs/crypto

CI: https://ci.nodejs.org/job/node-test-pull-request/908/

Contains fixes for:

* CVE-2015-3194 Certificate verify crash with missing PSS parameter
* CVE-2015-3195 X509_ATTRIBUTE memory leak
@bnoordhuis bnoordhuis added tls Issues and PRs related to the tls subsystem. crypto Issues and PRs related to the crypto subsystem. v0.10 labels Dec 3, 2015
@indutny
Copy link
Member

indutny commented Dec 3, 2015

LGTM if CI is happy

@mscdex mscdex added openssl Issues and PRs related to the OpenSSL dependency. and removed crypto Issues and PRs related to the crypto subsystem. tls Issues and PRs related to the tls subsystem. labels Dec 3, 2015
@bnoordhuis
Copy link
Member Author

New CI with opensslconf.h fix-up: https://ci.nodejs.org/job/node-test-pull-request/910/

@shigeki
Copy link
Contributor

shigeki commented Dec 3, 2015

linter check was bad in v0.10 but it does not caused by this PR. Otherwise CI is fine. LGTM

bnoordhuis added a commit that referenced this pull request Dec 3, 2015
Contains fixes for:

* CVE-2015-3194 Certificate verify crash with missing PSS parameter
* CVE-2015-3195 X509_ATTRIBUTE memory leak

fixup! character encoding noise

fixup! update opensslconf.h

PR-URL: #4132
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
@shigeki
Copy link
Contributor

shigeki commented Dec 3, 2015

Landed in ce0a488 . Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants