Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: consolidate AUTHORS entries for brettkiefer #40599

Closed
wants to merge 1 commit into from
Closed

meta: consolidate AUTHORS entries for brettkiefer #40599

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 25, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 25, 2021
@Trott
Copy link
Member Author

Trott commented Oct 25, 2021

@brettkiefer This uses a .mailmap entry to use your gmail.com address in favor of your trello.com address in AUTHORS. If you'd prefer the other way around, please leave a comment. Thanks!

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 25, 2021
@github-actions

This comment has been minimized.

Sign in to view
@Trott Trott requested review from lpinca and tniessen October 28, 2021 00:18
@Trott Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label Oct 28, 2021
@Trott
Copy link
Member Author

Trott commented Oct 28, 2021

This is the last of these consolidation PRs. Needs some reviews. Help?

@Trott Trott requested a review from jasnell October 28, 2021 15:35
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 28, 2021
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2021
@github-actions
Copy link
Contributor

Landed in e937662...babd73c

@github-actions github-actions bot closed this Oct 30, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 30, 2021
@Trott @nodejs-github-bot
meta: consolidate AUTHORS entries for brettkiefer
babd73c 
PR-URL: #40599
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@Trott Trott deleted the authors-bk branch October 30, 2021 00:38
targos pushed a commit that referenced this pull request Nov 6, 2021
@Trott @targos
meta: consolidate AUTHORS entries for brettkiefer
aa98c6b 
PR-URL: #40599
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@targos targos mentioned this pull request Nov 8, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
@Trott @BethGriggs
meta: consolidate AUTHORS entries for brettkiefer
ef46cb4 
PR-URL: #40599
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca Awaiting requested review from lpinca

@tniessen tniessen Awaiting requested review from tniessen

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @jasnell @MylesBorins @nodejs-github-bot