Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: include new public V8 headers in distribution #40423

Closed
wants to merge 1 commit into from
Closed

build: include new public V8 headers in distribution #40423

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 12, 2021

v8.h was split into a multitude of smaller headers.

Refs: #39876

@targos
build: include new public V8 headers in distribution
e725c17 
v8.h was split into a multitude of smaller headers.

Refs: nodejs#39876
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. labels Oct 12, 2021
@targos targos mentioned this pull request Oct 12, 2021
Merged
2 tasks
@targos targos added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 12, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40256/

@Mesteery Mesteery removed the needs-ci PRs that need a full CI run. label Oct 12, 2021
@github-actions github-actions bot mentioned this pull request Oct 13, 2021
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40272/

@BethGriggs BethGriggs added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 13, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @BethGriggs. Please 👍 to approve.

mhdawson
mhdawson approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

Landed in f9996d5

@mhdawson mhdawson closed this Oct 13, 2021
mhdawson pushed a commit that referenced this pull request Oct 13, 2021
@targos @mhdawson
build: include new public V8 headers in distribution
f9996d5 
v8.h was split into a multitude of smaller headers.

Refs: #39876

PR-URL: #40423
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@github-actions github-actions bot mentioned this pull request Oct 14, 2021
Open
22 tasks
@targos targos deleted the fix-install-py branch October 14, 2021 03:19
This was referenced Oct 15, 2021
Open
Open
This was referenced Oct 17, 2021
Open
Open
Open
@richardlau richardlau mentioned this pull request Oct 19, 2021
Closed
@kriszyp kriszyp mentioned this pull request Oct 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@mhdawson mhdawson mhdawson approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@targos @nodejs-github-bot @mhdawson @cjihrig @joyeecheung @richardlau @BethGriggs @aduh95 @Mesteery