-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix test-domain-with-abort-on-uncaught-exception.js on AIX #4008
Conversation
Add SIGTRAP as an expected signal when running on AIX. Port of f45c315 for v0.12
LGTM if the CI is happy |
@dnakamura, I think the original issue was seen on platforms other than AIX and was fixed so that it resolved those cases as well. Is the test in 0.12.X such that the fix was only needed for AIX ? Otherwise we should probably fix in a way similar to the original where it applies across platforms |
Yeah, however the style of the test in this case is aimed more on a case by case basis. Not entirely sure on how to implement while keeping with the style of the test |
Probably worth looking at the original issue to see what other platforms needed the same fix then at least we can include them in the if with AIX |
Actually if those platforms indicate the signal in the return code, it should be simple |
Ok, good to hear. I assume you'll update the patch to cover them |
Devin do you have an idea when you'll have the update covering the other platforms ? |
c7a7253
to
fcc6479
Compare
@dnakamura just wondering if you'll get to this soon |
@dnakamura ... ping |
ping, what's the status of this? we'll be at the end of v0.12 soon! |
Going to ask @iwuzhere if he can take this one over |
I'd agree with @iwuzhere I think this can just be closed. I'll close if anybody disagrees please re-open. |
Add SIGTRAP as an expected signal when running on AIX. To fix failing test. see #3239
backport of f45c315 for v0.12