module: fix $ pattern replacements #40044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
esm
aduh95
reviewed
Sep 8, 2021
aduh95
reviewed
Sep 8, 2021
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
approved these changes
Sep 8, 2021
aduh95
added
the
author ready
jasnell
approved these changes
Sep 9, 2021
himself65
approved these changes
Sep 10, 2021
guybedford
added a commit
that referenced
this pull request
Sep 12, 2021
PR-URL: #40044 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
|
Landed in 5c1adda. |
This was referenced Sep 14, 2021
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40044 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40044 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug where
import 'pkg/$$.js'will resolve topkg/$.jswhen using the exports pattern*.js -> *.js, due to the JS String replace DSL footgun (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace#specifying_a_string_as_a_parameter).Thanks to @Rich-Harris for sharing this one on Twitter - https://twitter.com/Rich_Harris/status/1435703344354451458.
@nodejs/modules