Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x] tools: make utils.SearchFiles Python2-compatible #40020

Closed
wants to merge 2 commits into from
Closed

[v14.x] tools: make utils.SearchFiles Python2-compatible #40020

wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 6, 2021

@targos targos mentioned this pull request Sep 6, 2021
Merged
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. v14.x labels Sep 6, 2021
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39835/

cclauss
cclauss requested changes Sep 6, 2021
View reviewed changes
@targos
Copy link
Member Author

targos commented Sep 6, 2021

Fixed. I chose matching_files for the variable name.

@targos targos requested a review from cclauss September 6, 2021 18:19
cclauss
cclauss approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39836/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39845/

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2021

Fast-track has been requested by @targos. Please 👍 to approve.

@targos
Copy link
Member Author

targos commented Sep 7, 2021

The Windows error is unrelated. I just need to cherry-pick 4fde7dc to staging

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 7, 2021
@targos
Copy link
Member Author

targos commented Sep 7, 2021

Landed in d39200c

@targos targos closed this Sep 7, 2021
@targos targos deleted the tools-py2 branch September 7, 2021 09:14
targos added a commit that referenced this pull request Sep 7, 2021
@targos
tools: make utils.SearchFiles Python2-compatible
d39200c 
PR-URL: #40020
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@github-actions github-actions bot mentioned this pull request Sep 14, 2021
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @nodejs-github-bot @cclauss @richardlau