Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: use validateArray #39774

Closed
wants to merge 1 commit into from
Closed

lib: use validateArray #39774

wants to merge 1 commit into from

Conversation

VoltrexKeyva
Copy link
Member

The validateArray() validator could be used to cleanup validation
and keep consistency.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support. labels Aug 15, 2021
@VoltrexKeyva
lib: use validateArray
c459a3b 
The `validateArray()` validator could be used to cleanup validation
and keep consistency.
@VoltrexKeyva VoltrexKeyva added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 3, 2021
@Ayase-252 Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 23, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Sep 24, 2021
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40067/

@github-actions github-actions bot mentioned this pull request Sep 26, 2021
Open
21 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40072/

@VoltrexKeyva VoltrexKeyva removed the needs-ci PRs that need a full CI run. label Sep 26, 2021
@Ayase-252 Ayase-252 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 26, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 26, 2021
@github-actions
Copy link
Contributor

Landed in b25a73f...256fe21

@github-actions github-actions bot closed this Sep 26, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 26, 2021
@VoltrexKeyva @nodejs-github-bot
lib: use validateArray
256fe21 
The `validateArray()` validator could be used to cleanup validation
and keep consistency.

PR-URL: #39774
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
@VoltrexKeyva VoltrexKeyva deleted the patch-3 branch September 26, 2021 12:59
This was referenced Sep 27, 2021
Open
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Oct 4, 2021
Open
22 tasks
targos pushed a commit that referenced this pull request Oct 4, 2021
@VoltrexKeyva @targos
lib: use validateArray
547fc86 
The `validateArray()` validator could be used to cleanup validation
and keep consistency.

PR-URL: #39774
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lxxyx Lxxyx Lxxyx approved these changes

@Ayase-252 Ayase-252 Ayase-252 approved these changes

@tniessen tniessen tniessen approved these changes

@XadillaX XadillaX XadillaX approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@VoltrexKeyva @nodejs-github-bot @jasnell @lpinca @XadillaX @tniessen @Ayase-252 @Lxxyx