Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix long path tests to avoid issue #2255 #3936

Closed
wants to merge 1 commit into from
Closed

test: fix long path tests to avoid issue #2255 #3936

wants to merge 1 commit into from

Conversation

rsp
Copy link
Contributor

@rsp rsp commented Nov 20, 2015

In test-fs-long-path.js and test-require-long-path.js:
Use os.tmpdir() on Linux if it is readable/writable
but only when the original tests fail
to avoid failing tests on ecryptfs filesystems
See issue #2255 and comments to PR #3925
Change vars to const per advice to PR #3929

@rsp
test: fix long path tests to avoid issue #2255
5194f3a 
In test-fs-long-path.js and test-require-long-path.js:
Use os.tmpdir() on Linux if it is readable/writable
but only when the original tests fail
to avoid failing tests on ecryptfs filesystems
See issue #2255 and comments to PR #3925
Change vars to const per advice to PR #3929
@rsp rsp mentioned this pull request Nov 20, 2015
Closed
@Fishrock123 Fishrock123 added the test Issues and PRs related to the tests. label Nov 20, 2015
@mscdex mscdex added fs Issues and PRs related to the fs subsystem / file system. module Issues and PRs related to the module subsystem. labels Nov 20, 2015
@jasnell jasnell added the stalled Issues and PRs that are stalled. label Mar 22, 2016
@jasnell
Copy link
Member

jasnell commented Mar 22, 2016

@nodejs/testing ... can anyone take a look at this?

@Trott
Copy link
Member

Trott commented Mar 22, 2016

As of 19e06d7 (which @rsp submitted after they submitted this PR), these tests are Windows only so these fixes aren't needed anymore. I'm guessing the intention was to close this PR when that landed, but that didn't happen. So, closing now! Feel free to comment if I'm mistaken.

@Trott Trott closed this Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. module Issues and PRs related to the module subsystem. stalled Issues and PRs that are stalled. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rsp @jasnell @Trott @mscdex @MylesBorins @Fishrock123