Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: put common lint exceptions into config file #39358

Merged
merged 1 commit into from
Jul 14, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: put common lint exceptions into config file
For lint exceptions that are universal or near universal for
`test/common`, put the exceptions in a config file rather than disabling
the ESLint rules at the top of each file.

PR-URL: #39358
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
  • Loading branch information
Trott committed Jul 14, 2021
commit c506660f326750a9cbde6a715b357d42d2c46a0a
3 changes: 3 additions & 0 deletions test/common/.eslintrc.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
rules:
node-core/required-modules: off
node-core/require-common-first: off
1 change: 0 additions & 1 deletion test/common/arraystream.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */
'use strict';

const { Stream } = require('stream');
2 changes: 0 additions & 2 deletions test/common/benchmark.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */

'use strict';

const assert = require('assert');
2 changes: 0 additions & 2 deletions test/common/countdown.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */

'use strict';

const assert = require('assert');
2 changes: 0 additions & 2 deletions test/common/cpu-prof.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */

'use strict';

require('./');
1 change: 0 additions & 1 deletion test/common/dns.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */
'use strict';

const assert = require('assert');
1 change: 0 additions & 1 deletion test/common/duplexpair.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */
'use strict';
const { Duplex } = require('stream');
const assert = require('assert');
1 change: 0 additions & 1 deletion test/common/fixtures.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */
'use strict';

const path = require('path');
1 change: 0 additions & 1 deletion test/common/fixtures.mjs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */
import fixtures from './fixtures.js';

const {
1 change: 0 additions & 1 deletion test/common/heap.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */
'use strict';
const assert = require('assert');
const util = require('util');
1 change: 0 additions & 1 deletion test/common/hijackstdio.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */
'use strict';

// Hijack stdout and stderr
1 change: 0 additions & 1 deletion test/common/http2.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */
'use strict';

// An HTTP/2 testing tool used to create mock frames for direct testing
1 change: 0 additions & 1 deletion test/common/index.js
Original file line number Diff line number Diff line change
@@ -19,7 +19,6 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* eslint-disable node-core/require-common-first, node-core/required-modules */
/* eslint-disable node-core/crypto-check */
'use strict';
const process = global.process; // Some tests tamper with the process global.
2 changes: 0 additions & 2 deletions test/common/index.mjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */

import { createRequire } from 'module';

const require = createRequire(import.meta.url);
1 change: 0 additions & 1 deletion test/common/internet.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */
'use strict';

// Utilities for internet-related tests
1 change: 0 additions & 1 deletion test/common/measure-memory.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */
'use strict';

const assert = require('assert');
1 change: 0 additions & 1 deletion test/common/report.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */
'use strict';
const assert = require('assert');
const fs = require('fs');
1 change: 0 additions & 1 deletion test/common/require-as.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */
'use strict';

if (require.main !== module) {
1 change: 0 additions & 1 deletion test/common/tls.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */
/* eslint-disable node-core/crypto-check */

'use strict';
1 change: 0 additions & 1 deletion test/common/tmpdir.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */
'use strict';

const fs = require('fs');
1 change: 0 additions & 1 deletion test/common/udppair.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */
'use strict';
const { internalBinding } = require('internal/test/binding');
const { JSUDPWrap } = internalBinding('js_udp_wrap');
1 change: 0 additions & 1 deletion test/common/wpt.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/require-common-first, node-core/required-modules */
'use strict';

const assert = require('assert');
2 changes: 0 additions & 2 deletions test/common/wpt/worker.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-disable node-core/required-modules,node-core/require-common-first */

'use strict';

const { runInThisContext } = require('vm');