test: put common lint exceptions into config file

For lint exceptions that are universal or near universal for `test/common`, put the exceptions in a config file rather than disabling the ESLint rules at the top of each file. PR-URL: #39358 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Trott · Jul 14, 2021 · Jul 11, 2021 · Jul 14, 2021 · c506660f326750a9cbde6a715b357d42d2c46a0a
commit c506660f326750a9cbde6a715b357d42d2c46a0a
diff --git a/test/common/.eslintrc.yaml b/test/common/.eslintrc.yaml
@@ -0,0 +1,3 @@
+rules:
+  node-core/required-modules: off
+  node-core/require-common-first: off
diff --git a/test/common/arraystream.js b/test/common/arraystream.js
@@ -1,4 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 'use strict';
 
 const { Stream } = require('stream');

diff --git a/test/common/benchmark.js b/test/common/benchmark.js
@@ -1,5 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
-
 'use strict';
 
 const assert = require('assert');

diff --git a/test/common/countdown.js b/test/common/countdown.js
@@ -1,5 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
-
 'use strict';
 
 const assert = require('assert');

diff --git a/test/common/cpu-prof.js b/test/common/cpu-prof.js
@@ -1,5 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
-
 'use strict';
 
 require('./');

diff --git a/test/common/dns.js b/test/common/dns.js
@@ -1,4 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 'use strict';
 
 const assert = require('assert');

diff --git a/test/common/duplexpair.js b/test/common/duplexpair.js
@@ -1,4 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 'use strict';
 const { Duplex } = require('stream');
 const assert = require('assert');

diff --git a/test/common/fixtures.js b/test/common/fixtures.js
@@ -1,4 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 'use strict';
 
 const path = require('path');

diff --git a/test/common/fixtures.mjs b/test/common/fixtures.mjs
@@ -1,4 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 import fixtures from './fixtures.js';
 
 const {

diff --git a/test/common/heap.js b/test/common/heap.js
@@ -1,4 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 'use strict';
 const assert = require('assert');
 const util = require('util');

diff --git a/test/common/hijackstdio.js b/test/common/hijackstdio.js
@@ -1,4 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 'use strict';
 
 // Hijack stdout and stderr

diff --git a/test/common/http2.js b/test/common/http2.js
@@ -1,4 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 'use strict';
 
 // An HTTP/2 testing tool used to create mock frames for direct testing

diff --git a/test/common/index.js b/test/common/index.js
@@ -19,7 +19,6 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 /* eslint-disable node-core/crypto-check */
 'use strict';
 const process = global.process;  // Some tests tamper with the process global.

diff --git a/test/common/index.mjs b/test/common/index.mjs
@@ -1,5 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
-
 import { createRequire } from 'module';
 
 const require = createRequire(import.meta.url);

diff --git a/test/common/internet.js b/test/common/internet.js
@@ -1,4 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 'use strict';
 
 // Utilities for internet-related tests

diff --git a/test/common/measure-memory.js b/test/common/measure-memory.js
@@ -1,4 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 'use strict';
 
 const assert = require('assert');

diff --git a/test/common/report.js b/test/common/report.js
@@ -1,4 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 'use strict';
 const assert = require('assert');
 const fs = require('fs');

diff --git a/test/common/require-as.js b/test/common/require-as.js
@@ -1,4 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 'use strict';
 
 if (require.main !== module) {

diff --git a/test/common/tls.js b/test/common/tls.js
@@ -1,4 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 /* eslint-disable node-core/crypto-check */
 
 'use strict';

diff --git a/test/common/tmpdir.js b/test/common/tmpdir.js
@@ -1,4 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 'use strict';
 
 const fs = require('fs');

diff --git a/test/common/udppair.js b/test/common/udppair.js
@@ -1,4 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 'use strict';
 const { internalBinding } = require('internal/test/binding');
 const { JSUDPWrap } = internalBinding('js_udp_wrap');

diff --git a/test/common/wpt.js b/test/common/wpt.js
@@ -1,4 +1,3 @@
-/* eslint-disable node-core/require-common-first, node-core/required-modules */
 'use strict';
 
 const assert = require('assert');

diff --git a/test/common/wpt/worker.js b/test/common/wpt/worker.js
@@ -1,5 +1,3 @@
-/* eslint-disable node-core/required-modules,node-core/require-common-first */
-
 'use strict';
 
 const { runInThisContext } = require('vm');