Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update g++ requirement from 4.8 to 4.8.5 #3915

Closed
wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

Lest people think that g++ 4.8.0, released in March 2013, is acceptable.
4.8.5 was released in June of this year and contains numerous bug fixes.

R=@misterdjules?

Lest people think that g++ 4.8.0, released in March 2013, is acceptable.
4.8.5 was released in June of this year and contains numerous bug fixes.
@bnoordhuis bnoordhuis added doc Issues and PRs related to the documentations. lts-watch-v4.x labels Nov 19, 2015
@rvagg
Copy link
Member

rvagg commented Nov 19, 2015

is this just because we can or are you aware of bugs in .0 -> .4 that are serious enough to warrant this as a strong recommendation?

@bnoordhuis
Copy link
Member Author

The context is #3391 (comment). It made me realize that using an old 4.8 release is potentially troublesome.

@mscdex mscdex added the build Issues and PRs related to build files or the CI. label Nov 19, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Nov 19, 2015

LGTM

@misterdjules
Copy link

According to GCC's ABI Policy and Guidelines, that would make the minimum C++ runtime requirements jump from GLIBCXX_3.4.18, CXXABI_1.3.7 to GLIBCXX_3.4.19, CXXABI_1.3.7.

So I think we would first need to:

  1. Demonstrate that no currently supported platforms will break
  2. There's an actual specific problem with using any other g++ 4.8.x version

@rvagg
Copy link
Member

rvagg commented Nov 19, 2015

@bnoordhuis I see the link to the gcc bugzilla which is interesting but doesn't highlight any specific bugs that would impact on builds.

Also, RHEL's devtoolset-2, the CERN variant of which we are using to compile the Linux binaries on CentOS5 only comes with 4.8.2. gcc version 4.8.2 20140120 (Red Hat 4.8.2-15) (GCC) to be exact. So -1 on bringing the requirements up even further than what we use ourselves.

@Fishrock123
Copy link
Contributor

I see no problem in doing this for the master branch?

@misterdjules
Copy link

@Fishrock123 I believe we'd have the same concerns for upgrading GCC requirements in the master branch than in the current LTS branch. If as a result the node binary doesn't run on some platforms we currently support, then the impact of that change should be at least evaluated and documented properly, and advance warning should be given to users of these platforms.

@Fishrock123
Copy link
Contributor

If as a result the node binary doesn't run on some platforms we currently support, then the impact of that change should be at least evaluated and documented properly, and advance warning should be given to users of these platforms.

I don't disagree, but consider if v8 uses something that bugs out in an older compiler, what do we do?

@misterdjules
Copy link

@Fishrock123

I don't disagree, but consider if v8 uses something that bugs out in an older compiler, what do we do?

That's an excellent question, but it is outside of the scope of this PR, unless we know of such a problem today. I suggested the following in #3391 (comment):

It seems that it would help to have a detailed matrix of the runtimes/OSes/platforms supported by the binaries available on nodejs.org. We could use that to communicate potential breakage when we want to bump the compiler/runtime requirements, or at least to understand exactly how bumping the minimum required compilers would impact the list of supported platforms.

@benjamingr
Copy link
Member

Status?

@jasnell jasnell added the stalled Issues and PRs that are stalled. label Mar 22, 2016
@bnoordhuis bnoordhuis closed this Apr 5, 2016
@bnoordhuis bnoordhuis deleted the update-compiler-req branch April 5, 2016 14:56
@jasnell jasnell removed lts-watch-v4.x stalled Issues and PRs that are stalled. labels Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants