-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update g++ requirement from 4.8 to 4.8.5 #3915
Conversation
Lest people think that g++ 4.8.0, released in March 2013, is acceptable. 4.8.5 was released in June of this year and contains numerous bug fixes.
is this just because we can or are you aware of bugs in .0 -> .4 that are serious enough to warrant this as a strong recommendation? |
The context is #3391 (comment). It made me realize that using an old 4.8 release is potentially troublesome. |
LGTM |
According to GCC's ABI Policy and Guidelines, that would make the minimum C++ runtime requirements jump from So I think we would first need to:
|
@bnoordhuis I see the link to the gcc bugzilla which is interesting but doesn't highlight any specific bugs that would impact on builds. Also, RHEL's devtoolset-2, the CERN variant of which we are using to compile the Linux binaries on CentOS5 only comes with 4.8.2. |
I see no problem in doing this for the |
@Fishrock123 I believe we'd have the same concerns for upgrading GCC requirements in the master branch than in the current LTS branch. If as a result the node binary doesn't run on some platforms we currently support, then the impact of that change should be at least evaluated and documented properly, and advance warning should be given to users of these platforms. |
I don't disagree, but consider if v8 uses something that bugs out in an older compiler, what do we do? |
That's an excellent question, but it is outside of the scope of this PR, unless we know of such a problem today. I suggested the following in #3391 (comment):
|
Status? |
Lest people think that g++ 4.8.0, released in March 2013, is acceptable.
4.8.5 was released in June of this year and contains numerous bug fixes.
R=@misterdjules?