Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix markup for aesImportParams #38898

Closed
wants to merge 1 commit into from
Closed

doc: fix markup for aesImportParams #38898

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Jun 2, 2021

No description provided.

@github-actions github-actions bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Jun 2, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jun 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2021

Fast-track has been requested by @aduh95. Please 👍 to approve.

bl-ue
bl-ue approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't caught by the linter?

@Lxxyx Lxxyx added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2021
@github-actions
Copy link
Contributor

Landed in a596fdf...76ebad0

@github-actions github-actions bot closed this Jun 11, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jun 11, 2021
@tniessen @nodejs-github-bot
doc: fix markup for aesImportParams
76ebad0 
PR-URL: #38898
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
@tniessen @targos
doc: fix markup for aesImportParams
7b21999 
PR-URL: #38898
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jun 17, 2021
@tniessen @danielleadams
doc: fix markup for aesImportParams
de721a7 
PR-URL: #38898
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@richardlau
Copy link
Member

Webcrypto is marked semver-major (#35093) so marking this as dont-land-on-v14.x.

@tniessen tniessen deleted the doc-aesImportParams branch October 7, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bl-ue bl-ue bl-ue approved these changes

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@aduh95 aduh95 aduh95 approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tniessen @richardlau @lpinca @cjihrig @Lxxyx @aduh95 @RaisinTen @HarshithaKP @bl-ue