Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dgram: remove unreachable connectState assign #38590

Merged
merged 1 commit into from
Jan 20, 2022
Merged

dgram: remove unreachable connectState assign #38590

merged 1 commit into from
Jan 20, 2022

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented May 8, 2021 •
edited
Loading

isConnected() returns true implies that remoteAddress() doesn't throw an error. The implementation of remoteAddress is as follows:

node/lib/dgram.js

Lines 770 to 775 in 29f1b60

Socket.prototype.remoteAddress = function() {
healthCheck(this);
const state = this[kStateSymbol];
if (state.connectState !== CONNECT_STATE_CONNECTED)
throw new ERR_SOCKET_DGRAM_NOT_CONNECTED();

It also implies that state.connectState === CONNECT_STATE_CONNECTED.

So it seems not necessary to assign it again.

@github-actions github-actions bot added dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. labels May 8, 2021
@pd4d10
Copy link
Contributor Author

pd4d10 commented May 8, 2021

Another thing which needs to check is that calling isConnect() has no side effect.

AFAICT it doesn't, but it is better to check again in the code review.

@oyyd oyyd added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 24, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 24, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41644/

This was referenced Dec 25, 2021
Open
Open
Open
@oyyd
Copy link
Contributor

oyyd commented Dec 27, 2021

@pd4d10 Can you rebase against master? (so that we might have luck to get a green CI)

@oyyd oyyd added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41670/

This was referenced Dec 28, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 4, 2022
Open
Open
@aduh95
Copy link
Contributor

aduh95 commented Jan 5, 2022

It looks like there are some relevant CI failure. Also could you rebase instead of marging? Merge commits tend to break our tooling.

@aduh95 aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 5, 2022
@oyyd oyyd added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41762/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 5, 2022
@github-actions github-actions bot mentioned this pull request Jan 6, 2022
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41770/

This was referenced Jan 7, 2022
Open
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Jan 14, 2022
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41956/

@github-actions github-actions bot mentioned this pull request Jan 18, 2022
Open
16 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41996/

This was referenced Jan 19, 2022
Open
Open
@oyyd
Copy link
Contributor

oyyd commented Jan 20, 2022

The CI is green now.

/cc @nodejs/dgram for more reviews.

mcollina
mcollina approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 20, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 20, 2022
@nodejs-github-bot nodejs-github-bot merged commit 5753eb1 into nodejs:master Jan 20, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 5753eb1

@pd4d10 pd4d10 deleted the patch-10 branch January 20, 2022 09:04
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@pd4d10 @BethGriggs
dgram: remove unreachable connectState assign
0d4f043 
PR-URL: #38590
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@pd4d10 @Linkgoron
dgram: remove unreachable connectState assign
6fcb414 
PR-URL: nodejs#38590
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
@pd4d10 @danielleadams
dgram: remove unreachable connectState assign
0e18030 
PR-URL: #38590
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@pd4d10 @danielleadams
dgram: remove unreachable connectState assign
8b3749f 
PR-URL: #38590
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@pd4d10 @danielleadams
dgram: remove unreachable connectState assign
fafd13b 
PR-URL: #38590
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@pd4d10 @danielleadams
dgram: remove unreachable connectState assign
9062479 
PR-URL: #38590
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyyd oyyd oyyd approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pd4d10 @nodejs-github-bot @oyyd @aduh95 @mcollina