-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debugger: refactor inspect_repl
to use primordials
#38551
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
inspector
Issues and PRs related to the V8 inspector protocol
needs-ci
PRs that need a full CI run.
labels
May 5, 2021
aduh95
force-pushed
the
inspector-primordials
branch
from
May 7, 2021 09:49
8fd8135
to
db42730
Compare
Trott
approved these changes
May 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamp LGTM if CI is green.
This comment has been minimized.
This comment has been minimized.
aduh95
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 9, 2021
jasnell
approved these changes
May 10, 2021
This comment has been minimized.
This comment has been minimized.
Landed in 284f74d |
jasnell
pushed a commit
that referenced
this pull request
May 14, 2021
PR-URL: #38551 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 17, 2021
PR-URL: #38551 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Jul 19, 2021
PR-URL: nodejs#38551 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Jul 20, 2021
PR-URL: nodejs#38551 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Jul 20, 2021
PR-URL: nodejs#38551 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Jul 22, 2021
PR-URL: #38551 Backport-PR-URL: #39446 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Jul 22, 2021
PR-URL: #38551 Backport-PR-URL: #39446 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
PR-URL: nodejs#38551 Backport-PR-URL: nodejs#39446 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
inspector
Issues and PRs related to the V8 inspector protocol
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.