test: module loading error fix solaris #3798

[claudiorodriguez]

• refactor test-module-loading-error to accept multiple error messages per
  platform
• add new message to be found in Solaris 11.3 as per node5: test-module-loading-error.js fails #3798

[jasnell]

LGTM

[jasnell]

CI: https://ci.nodejs.org/job/node-test-pull-request/746/

[cjihrig]

Could this whole change be:

assert.strictEqual(dlerror_msg.some((errMsgCase) => {
  return e.message.indexOf(errMsgCase) !== -1;
}), true);

[jasnell]

There are CI failures for this one

[claudiorodriguez]

@cjihrig That looks much simpler, thanks

@jasnell
Error (in centos-32) seems to be:
Looking for TAP results report in workspace using pattern: test.tap
ERROR: Build step failed with exception
/home/iojs/build/workspace/node-test-commit-linux/nodes/centos5-32 does not exist.

But the test itself runs (haven't found a "not ok" on this test on any of the logs unless I'm missing something)
ok 500 test-module-loading-error.js

---

duration_ms: 0.183

How would I go about figuring out what's wrong?

[evanlucas]

Can you update the commit message to match the contribution guidelines in https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit. The first line should not exceed 50 characters, the second line should be blank, and the remaining lines should not exceed 72 characters.

LGTM other than that.

I also started a new CI run since the last one seemed a bit off. https://ci.nodejs.org/job/node-test-pull-request/770/

[claudiorodriguez]

@evanlucas done.
That CI seems to also have failures, but I don't really understand why.
Should I try going back to the last stable build on CI (02fd81a or 7c7f131) and adding the change on top of that?

EDIT: seems like there's a lot of PRs having issues with CI at the moment

[evanlucas]

Thanks! No, those failures are known issues from flaky tests.

[evanlucas]

Landed in 9a628e2. Thanks!