util: use Object.create(null) for dictionary object #3831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3788 `arrayToHash()` needs to use `Object.create(null)` for its dictionary object.
|
Given the LGTM's in the prior PR, will get this landed. |
jasnell
pushed a commit
that referenced
this pull request
Nov 16, 2015
Fixes #3788 `arrayToHash()` needs to use `Object.create(null)` for its dictionary object. Refs: #3791 PR-URL: #3831 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 9d0396c |
|
This should probably be semver-major? |
|
@nodejs/ctc ... any thoughts on the semver-iness of this change? |
|
This is a grey area. I would consider it a bug fix, but technically someone could be depending on the brackets described in #3788. |
|
I'd say bug fix as well. |
Fishrock123
pushed a commit
that referenced
this pull request
Nov 17, 2015
Fixes #3788 `arrayToHash()` needs to use `Object.create(null)` for its dictionary object. Refs: #3791 PR-URL: #3831 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Closed
|
Given the nature of the change and the possibility that this could break someone, I'm not going to pull this into v4 at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3788
arrayToHash()needs to useObject.create(null)for its dictionary object.