Revert "lib: add WeakRef and FinalizationRegistry to primordials"

[BethGriggs]

Initially opening as a test to see if this fixes our actions runs.

Refs:

• local fatal error for test/js-native-api/test_object/test.js #38040 (comment)
• https://github.com/nodejs/node/runs/2332565053

---

This reverts commit 78343bb.

[BethGriggs]

Looks like #38211 was dependent on this, so this revert is failing the linter run. I'll see how the other runs go, but I'm guessing we'd potentially need to revert both to get back to passing runs.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37471/

[targos]

Even if this makes the run green I'm not convinced it's the right move. The reverted PR did not introduce the bug, it made it more visible.

[BethGriggs]

@targos, the motivation for this PR was that when the actions are not green across the board, it raises the chance of other failures slipping through (and it appears PR #37263 landed with the failures).

Do you have an alternative suggestion? I skimmed through the linked issues, and #38000 did not appear to be imminently ready to land.

[targos]

The alternative is to skip or mark the test flaky

[jasnell]

If the test is failing consistently on every run then it's not flaky, it's just broken. My preference would be to go ahead and revert so that we can make sure CI is green, fix the test, then re-land the reverted change.

[targos]

If something should be reverted, it's the change that broke the test in the first place, not another unrelated change that happens to make it red in CI. That test has been failing on my machine for several days already

[aduh95]

Looks like #38211 was dependent on this, so this revert is failing the linter run. I'll see how the other runs go, but I'm guessing we'd potentially need to revert both to get back to passing runs.

Actually it's not dependent, you only need to use globalThis from primordials to fix the linter issue. I can take care of this if you want.

[BethGriggs]

Actually it's not dependent, you only need to use globalThis from primordials to fix the linter issue. I can take care of this if you want.

I meant dependent in the sense that I couldn't just revert 78343bb alone. I'll leave fixing the actions to folks who are more familiar with errors.