test: fix flaky test-vm-memleak #38054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Trott
added
the
flaky-test
|
Pummel tests aren't run (yet) in node-test-pull-request CI jobs, so the pummel CI above should be sufficient here. |
targos
approved these changes
Apr 3, 2021
2 tasks
cjihrig
approved these changes
Apr 3, 2021
|
(This fixes it on FreeBSD and probably elsewhere, but the test reliably fails on AIX, probably because the baseline RSS is too high. I'll adjust the test further in another PR to address AIX specifically.) |
lpinca
approved these changes
Apr 3, 2021
Force garbage collection so that the memory leak is more easily differentiated from ordinary not-garbage-collected memory. Refs: nodejs#34289 PR-URL: nodejs#38054 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 4f387c2 |
targos
pushed a commit
that referenced
this pull request
Sep 7, 2021
Force garbage collection so that the memory leak is more easily differentiated from ordinary not-garbage-collected memory. Refs: #34289 PR-URL: #38054 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force garbage collection so that the memory leak is more easily
differentiated from ordinary not-garbage-collected memory.
Refs: #34289