Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve code coverage in webcrypto API #38052

Closed
wants to merge 1 commit into from
Closed

test: improve code coverage in webcrypto API #38052

wants to merge 1 commit into from

Conversation

juanarbol
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 3, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@juanarbol juanarbol added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Apr 5, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37171/

@marsonya marsonya added the coverage Issues and PRs related to native coverage support. label Apr 6, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37187/

@jasnell
Copy link
Member

jasnell commented Apr 6, 2021

Landed in 30d7f05

@jasnell jasnell closed this Apr 6, 2021
jasnell pushed a commit that referenced this pull request Apr 6, 2021
@juanarbol @jasnell
test: improve code coverage in webcrypto API
30d7f05 
PR-URL: #38052
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@juanarbol juanarbol deleted the juanarbol/improve-code-coverage-crypto branch April 9, 2021 21:07
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
@molllyn1 molllyn1 mentioned this pull request Jun 8, 2023
Open
This was referenced Jun 8, 2023
Open
Open
@ron-a20 ron-a20 mentioned this pull request Jun 8, 2023
Open
@baby636 baby636 mentioned this pull request Jun 9, 2023
Open
@137717unity 137717unity mentioned this pull request Jun 9, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Jun 9, 2023
Open
@kissofire kissofire mentioned this pull request Jun 25, 2023
Open
@kissofire kissofire mentioned this pull request Sep 28, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Sep 28, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Sep 28, 2023
Open
@137717unity 137717unity mentioned this pull request Sep 28, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Sep 28, 2023
Open
@baby636 baby636 mentioned this pull request Sep 28, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. coverage Issues and PRs related to native coverage support. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@juanarbol @nodejs-github-bot @jasnell @Trott @benjamingr @lpinca @targos @marsonya